On 12/13/2015 08:58 AM, Zac Medico wrote: > On 12/13/2015 04:58 AM, Michał Górny wrote: >>>> 39d81c5 portage.package.ebuild.config.config.__getitem__(): Partially drop >>>> backward compatibility for nonexistent keys. >>>> >>>> Maybe keep it but needs someone smarter than me to review. >>> >>> Looks good, except the last hunk seems redundant because "for x in self" >>> should only yield valid keys: >>> >>> @@ -2697,7 +2714,9 @@ class config(object): >>> for x in self: >>> if x in environ_filter: >>> continue >>> - myvalue = self[x] >>> + myvalue = self.get(x) >>> + if myvalue is None: >>> + continue >> >> Could you fix it then, please? > > Fixed: > > https://gitweb.gentoo.org/proj/portage.git/commit/?id=6ba56ad7be84b18dcbf15e8c6b283f5a9a559123 >
I've also fixed a blanket except clause from the same commit, so it will raise BaseException (like SystemExit and KeyboardInterrupt): https://gitweb.gentoo.org/proj/portage.git/commit/?id=ee7978914f27c6a48cd1d6ee2667470aed25687f -- Thanks, Zac
