On Sun, 10 Jan 2016 14:28:51 -0800 Brian Dolbec <[email protected]> wrote:
> On Sun, 10 Jan 2016 13:40:08 -0800 > Brian Dolbec <[email protected]> wrote: > > > I have now pushed a fully rebased, properly sequenced commit > > history to the repoman branch. To be honest I think all the > > rebasing, re-testing took as much time as the initial conversion > > and testing. Anyway, I consider the branch now ready for final > > review. Since there are a total of 45 commits. I am not sending > > them to the list at this time. They are available for review via > > the repoman branch at > > > > https://gitweb.gentoo.org/proj/portage.git/log/?h=repoman > > > > https://github.com/gentoo/portage/commits/repoman > > > > or github pull request for commit order convienience > > > > https://github.com/gentoo/portage/pull/22 > > > > But please try to follow our standard rules and reply with any > > comments or code review to this email thread. > > OK, There are 2 test failures I need to fix. The patch to the plugin > system seems to have broken emaint. Also there is one repoman test > failure which is I think related to the metadata.dtd url change. > I've fixed and rebased in the emaint breakage. As for the repoman test failure. The test data set up for test_simple has None as the vcs type. When I added code to get past the vcs_preserves_mtime check. It then fails for the ${VCS}changes file and class. So, it looks like I need to create a "None" vcs plugin. Then it will handle all info/functions just like any of the real vcs types. This is a side effect of spltting up the code from if cvs in ('foo', 'bar')... code into self directing code for the vcs type. -- Brian Dolbec <dolsen>
