On Sun, Mar 26, 2017 at 12:07 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 26 Mar 2017 03:13:11 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Implement the add_done_callback and remove_done_callback methods, >> since they are required in order to make further progress toward >> asyncio compatibility. >> >> Also implement the AbstractEventLoop create_future method for the >> EventLoop class, so that it returns an instance of _EventLoopFuture. >> EventLoop currently does not implement some of the >> asyncio.AbstractEventLoop methods that asyncio.Future requires for >> its add_done_callback implementation, and the create_future method >> conveniently solves this problem. >> >> X-Gentoo-bug: 591760 >> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=591760 >> --- >> pym/portage/tests/ebuild/test_ipc_daemon.py | 3 +- >> .../tests/util/eventloop/test_call_soon_fifo.py | 6 +- >> pym/portage/tests/util/futures/__init__.py | 0 >> pym/portage/tests/util/futures/__test__.py | 0 >> .../tests/util/futures/test_done_callback.py | 35 +++++++++ >> pym/portage/util/_async/SchedulerInterface.py | 3 +- >> pym/portage/util/_eventloop/EventLoop.py | 14 ++++ >> pym/portage/util/futures/futures.py | 82 >> ++++++++++++++++++++-- 8 files changed, 132 insertions(+), 11 >> deletions(-) create mode 100644 >> pym/portage/tests/util/futures/__init__.py create mode 100644 >> pym/portage/tests/util/futures/__test__.py create mode 100644 >> pym/portage/tests/util/futures/test_done_callback.py >> > > looks fine... /me ignoring the lack of parameters descriptions in the > docstrings
Yeah, I skipped parameter docstrings because the interfaces are compatible with the python standard libraries. Pushed: https://gitweb.gentoo.org/proj/portage.git/commit/?id=4b12ed04ec6b99f5a948e0eea5778a4fac502740 -- Thanks, Zac
