The patch is looking really good now. Thanks for working on this!
On Fri, Jul 28, 2017 at 2:59 AM, Manuel Rüger <mr...@gentoo.org> wrote:
> @@ -518,6 +526,26 @@ def doebuild_environment(myebuild, mydo, myroot=None,
> settings=None,
> mysettings["KV"] = ""
> mysettings.backup_changes("KV")
>
> + binpkg_compression = mysettings.get("BINPKG_COMPRESSION",
> "bzip2")
> + try:
> + compression = _compressors[binpkg_compression]
> + except KeyError as e:
> + writemsg("Warning: Invalid or unsupported compression
> method: %s" % e.args[0])
> + else:
> + try:
> + compression_binary =
> shlex_split(varexpand(compression["compress"], mydict=settings))[0]
> + except IndexError as e:
> + writemsg("Warning: Invalid or unsupported
> compression method: %s" % e.args[0])
> + else:
> + if find_binary(compression_binary) is None:
> + missing_package =
> compression["package"]
> + writemsg("Warning: File compression
> unsupported %s. Missing package: %s" % (binpkg_compression, missing_package))
It's going to be very helpful if we add some code to detect this case
in emerge's action_build function, and exit unsuccessfully if the
global BINPKG_COMPRESSION setting is invalid or the required package
is missing. This will ensure that people don't build a bunch of binary
packages, only to find out later that their BINPKG_COMPRESSION setting
was ineffective.
--
Thanks,
Zac
