James Broadhead <jamesbroadhead <at> gmail.com> writes:
> You seem to be talking about doing a few different things, none of > which is _quite_ what I'd call a code review. Well my experience is if you cannot hack the code a little bit, reviews of just reading and using parsing tools, are mostly benign in performing a solid code review.... ymmv. > If you want to work on writing patches for it, then it doesn't make as > much sense. Some times code changes rarely. Like minicom. There is no GIT or repository activity that amounts to anything. In general, with active projects, you are right. Much of what I'm doing is cleaning up old, neglected code, that most do not use anymore.... > So basically, I'm advising you to check out from upstream's version > control, work on your patching inside the checkout, perform builds, > but don't "make install". Run the test builds from your development > folder (that way you can have $APP-nopatch installed and working > system-wide, and can compare to it while you're testing). Once your > patch is ready, create a local overlay + update the ebuild to apply > your patch. Finally, file those bug reports! I have to delete much of your message to use gmane.... Anyway, I agree with and like your suggestions. I'm also reading some docs I found on overlays and gentoo development. I guess I'll survey all of the ideas and then mostly use what I'm use to, in a gentoo_ish approach. Thanks to you and Paul for posting. Yes, I'll post the patches somewhere. Some may not be appropriate for gentoo mainline. James
