Hello! Please feel free to modify the Makefile and open a pull request! What you mention about return values not checked, I believe they are part of sc, but please specify them if you can, since there's still a lot of sc for modify. Thanks!
Andrés M. 2014-11-04 10:23 GMT-03:00 Alec Ten Harmsel <a...@alectenharmsel.com>: > > On 11/02/2014 06:16 PM, Andrés Martinelli wrote: > > Hello there!! > > I am working on a terminal spreadsheet based on "sc", but with some > > adds like undo/redo.. > > you can find it here: > > > > https://github.com/andmarti1424/scim > > > > Any new ideas and/or contribution is always welcome! > > Thanks! > > > > -- > > Andrés M. > > If I can offer some constructive criticism based on my short experience > helping Walter: > > * Your build process could use some work; you shouldn't be hard-coding > variable values like LN and CC in a Makefile, these are handled by make. > Your Makefile could be shortened by ~150 lines by relying on built-in > rules and using some built-in make expressions to list your source files > as well. > * A bunch of your .c or .h files are marked as executable... why? > * No install command. Not really a huge deal as only one important file > is produced (src/scim), but would be nice to have > > If you're unfamiliar with make and have no immediate plans to switch to > either the autotools or cmake, I would be more than willing to make some > changes to your Makefile and open a pull request. If you would like to > email me personally with questions about make, feel free to do that as > well. > > There are a couple things I saw in the code as well: > > * system("echo -n 'Press enter to return.'") > * Lot of ignored return values on functions that you should check, like > write() and fgets() > > If these were in the sc code and you know about them but just haven't > gotten to fixing them yet, no worries. > > Alec > > -- Andrés Martinelli
