I like Vicky's interpretation better :)
> -----Original Message----- > From: geos-devel [mailto:[email protected]] On Behalf Of > Paul Ramsey > Sent: Monday, July 23, 2018 6:22 PM > To: GEOS Development List <[email protected]> > Subject: Re: [geos-devel] PSC Vote Add Vicky Vergara as GEOS committer > > WRT = with regard to > > On Mon, Jul 23, 2018 at 3:10 PM, Vicky Vergara <[email protected]> > wrote: > > forgot to mention > > > > I will certainly WRT (Work, Review and Test) > > > > On Mon, Jul 23, 2018 at 1:09 PM, Paul Ramsey > > <[email protected]> > > wrote: > >> > >> On Sun, Jul 22, 2018 at 2:13 PM, Vicky Vergara <[email protected]> > >> wrote: > >> > I wanted to start with changing the for loops to range loops, and > >> > chose PolygonizeGraph class as first C++ class where to do the changes. > >> > but when I started doing that small change, I just couldn't stop > >> > myself from using c++11 goodies on PolygonizeGraph. > >> > Now the file does not look at all as the original (big smile) java > >> > is not C++, so C++ does not need to look like java, now, in my > >> > opinion, the code on PolygonizeGraph looks more like C++. > >> > > >> > > >> > https://github.com/libgeos/geos/compare/master...cvvergara:Polygoni > >> > zeGraph > >> > >> As Sandro noted, the more we drift from the Java the more "fun" > >> porting changes will be. > >> WRT your branch, the mixture of formatting with actual changes makes > >> it hard to find the real work. > >> Also, you're imposing your syntactical style rather than matching it, > >> things like indentation, etc, etc. > >> I understand the mental place you're coming from doing that, I come > >> from that place too, but since everyone has different styles, can you > >> stick to real changes, and we can all agree (?) on a post-commit > >> formatter? > >> P. > >> _______________________________________________ > >> geos-devel mailing list > >> [email protected] > >> https://lists.osgeo.org/mailman/listinfo/geos-devel > > > > > > > > > > -- > > > > Georepublic UG (haftungsbeschr nkt) > > Salzmannstra e 44, > > 81739 M nchen, Germany > > > > Vicky Vergara > > Operations Research > > > > eMail: [email protected] > > Web: https://georepublic.info > > > > Tel: +49 (089) 4161 7698-1 > > Fax: +49 (089) 4161 7698-9 > > > > Commercial register: Amtsgericht M nchen, HRB 181428 > > CEO: Daniel Kastl > > > > > > _______________________________________________ > > geos-devel mailing list > > [email protected] > > https://lists.osgeo.org/mailman/listinfo/geos-devel > _______________________________________________ > geos-devel mailing list > [email protected] > https://lists.osgeo.org/mailman/listinfo/geos-devel _______________________________________________ geos-devel mailing list [email protected] https://lists.osgeo.org/mailman/listinfo/geos-devel
