Cool, don't worry so, that's quite what I wanted to know. If its used its used, period.
My real concern is more about the lack of unit tests, and documentation. Two places where we do the later: GetMapKvpReader javadocs and <http://geoserver.org/display/GEOSDOC/WMS+vendor+parameters>. I guess we don't have a wiki page with the official parameters we support though? Any help with unit testing the coverage side of execute would be highly appreciated too. Cheers, Gabriel On Friday 02 May 2008 09:00:33 pm Alexander Petkov wrote: > Ouch... I was about to use it. > > The code essentially passes time and elev parameters to the netcdf > plugin that we are using (Cedric worked on that) for selecting 2D > slices in order to make a map. > > > Alex > > On Fri, May 2, 2008 at 11:54 AM, Gabriel Roldán <[EMAIL PROTECTED]> wrote: > > Hi all, > > > > This is a call to know if anyone of you is relying on the setting of > > TIME and ELEVATION parameters in WMS GetMap. > > > > Take this as an alert, since I'm going to delete some code that, as far > > as aaime, simboss and myself can say, its unused. > > > > I don't even fully understand what it does, but that's because I'm > > fairly ignorant about coverages processing. > > > > The code in question is, for trunk, at GetMapResponse.execute, lines 346 > > to 378, and is copied bellow. > > > > Some says the geotools NETCDF plugin may be relying on it. > > > > Gabriel > > > > /* > > * Test if the parameter "TIME" is present in the > > WMS * request, and by the way in the reading parameters. If > > * it is the case, one can adds it to the > > request. If an > > * exception is thrown, we have nothing to do. > > */ > > try { > > ParameterValue time = > > reader.getFormat().getReadParameters().parameter( > > "TIME"); > > if (time != null && request.getTime() != > > null) { time.setValue(request.getTime()); } > > } catch (ParameterNotFoundException p) { > > } > > > > // uncomment when the DIM_RANGE vendor parameter > > will be enabled > > // try { > > // ParameterValue dimRange = > > reader.getFormat().getReadParameters() > > // .parameter("DIM_RANGE"); > > // if (dimRange != null && > > request.getDimRange() != null) { > > // > > dimRange.setValue(request.getDimRange()); // } > > // } catch (ParameterNotFoundException p) { > > // } > > > > try { > > ParameterValue elevation = > > reader.getFormat().getReadParameters() > > .parameter("ELEVATION"); > > if (elevation != null && > > request.getElevation() != null) { > > > > elevation.setValue(request.getElevation().intValue()); > > } > > } catch (ParameterNotFoundException p) { > > } > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't > > miss this year's exciting event. There's still time to save $100. Use > > priority code J8TL2D2. > > > > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/ja > >vaone _______________________________________________ > > Geoserver-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > !DSPAM:4045,481b64d3273981849620573! ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
