Chris Holmes ha scritto: > So it's been a desire for awhile to do more code review in GeoServer. I > know Andrea and Justin pass things back and forth, and I think many of > us at least glance over the commits lists to review commits there. But > there's a couple great web based tools that are making it easier to do > good code reviews, which I think we should probably evaluate for use > soon and pick one. > > The latest one is Google's rietveld, which is similar to what they use > internally. > > http://googleappengine.blogspot.com/2008/05/open-source-app-rietveld-code-review.html > > > http://code.google.com/appengine/articles/rietveld.html > > It's open source, but I'm not sure if it's limited to running only on > app engine, which seems likely. I do have an app engine account though, > so we could put it up there. > > The other is Atlassian's Crucible. I met the licensing guy for them > yesterday, and he said we should just be able to click a button and get it. > > http://www.atlassian.com/software/crucible/ > > Closed source, but free licenses for os projects like us, and we can run > it on our own servers, if that's desired.
The rietveld workflow seems a little odd to me, in that you have to separately push a diff for review on the server... I fear those extra steps would just slow down development futher. Crucible description seems to suggest the review works after commit, which is more like it imho. This works well for smaller patches and if you have a big change, I guess one can always roll out a short lived branch no? Review after commit also allows the reviews to checkout and run the code in a debugger, which may some time come in handy. Finally, I think we all have our hands very full, so the commit/review cycle would at least ensure that the patch does not get blocked out due to lack of reviewer's time. Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
