Ciao Justin, I am generally +1 but there is a but for which I could be still -1 (don't get upset yet ;) ).
The only thing that I do not like (and I did not like abut ETJ implementation either) is that we call a DAO what in reality should be a facade. Let me explain, I personally prefer DAOs to be stupid simple and expose CRUD operations on a single class or hierarchy. Above that you can create a facade that uses the various DAOs adding some more logic that goes beyond what a single stupid simple DAO can do ad take into account higher level constraints. The thing is that at this point are already into the business logic level and using the postfix DAO is confusing for me. I know this is subtle, but from my experience this can be a life-savior whenever you have tricky problems since layering things that way clearly separate pure data access code from code that include business logic about maintain the integrity of the ER model itself. So, I would like to hear from you about these concerns, if you don't have to address them, I don't want to be a showstopper and I will go +0. Ciao, Simone. ------------------------------------------------------- === Notice that our office phone number has recently changed! Please, update your records! === Ing. Simone Giannecchini GeoSolutions S.A.S. Founder Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584962313 fax: +39 0584962313 mob: +39 333 8128928 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.linkedin.com/in/simonegiannecchini http://twitter.com/simogeo ------------------------------------------------------- On Fri, Oct 22, 2010 at 5:59 PM, Justin Deoliveira <[email protected]> wrote: > Thanks for voting folks. I have updated the proposal. > We have yet to officially hear from Simone, Mark, and Ben. Ben is on > vacation so probably won't hear from him. So i guess we can leave him 0 if > we have enough positive votes from the others. > Andrea has said he would like to do an in depth review of the patch, > possibly over the weekend? I have updated the patch in preparation, adding > some javadocs to the CatalogDAO interface. > http://jira.codehaus.org/secure/attachment/51796/GEOS-3806.patch > -Justin > On Thu, Oct 21, 2010 at 9:07 PM, Rob Atkinson <[email protected]> > wrote: >> >> +0 (i havent had time to think about the approach, but support the >> concept), >> >> >> >> On Thu, Oct 21, 2010 at 7:49 PM, Jody Garnett <[email protected]> >> wrote: >> > I tried to indicate my +1 last week. I am excited by the technical >> > direction. >> > Jody >> > >> > >> > On Tue, Oct 19, 2010 at 11:54 PM, Justin Deoliveira >> > <[email protected]> wrote: >> >> Hi all, >> >> I am not sure if i made it clear when i posted the GSIP last week but i >> >> would like to move it forward through voting. So far I have no votes on >> >> this >> >> proposal from any PSC members. >> >> Thanks. >> >> -Justin >> >> -- >> >> Justin Deoliveira >> >> OpenGeo - http://opengeo.org >> >> Enterprise support for open source geospatial. >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> Download new Adobe(R) Flash(R) Builder(TM) 4 >> >> The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly >> >> Flex(R) Builder(TM)) enable the development of rich applications that >> >> run >> >> across multiple browsers and platforms. Download your free trials >> >> today! >> >> http://p.sf.net/sfu/adobe-dev2dev >> >> _______________________________________________ >> >> Geoserver-devel mailing list >> >> [email protected] >> >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> >> >> >> >> > >> > >> > ------------------------------------------------------------------------------ >> > Nokia and AT&T present the 2010 Calling All Innovators-North America >> > contest >> > Create new apps & games for the Nokia N8 for consumers in U.S. and >> > Canada >> > $10 million total in prizes - $4M cash, 500 devices, nearly $6M in >> > marketing >> > Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store >> > http://p.sf.net/sfu/nokia-dev2dev >> > _______________________________________________ >> > Geoserver-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > > > -- > Justin Deoliveira > OpenGeo - http://opengeo.org > Enterprise support for open source geospatial. > > ------------------------------------------------------------------------------ > Nokia and AT&T present the 2010 Calling All Innovators-North America contest > Create new apps & games for the Nokia N8 for consumers in U.S. and Canada > $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing > Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store > http://p.sf.net/sfu/nokia-dev2dev > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
