> > May be the easiest way forward would be for the > > TransactionPlugin.afterTransaction(TransactionType request, boolean > > committed) method to also receive the TransactionResponseType response > > so implementations can get to the InsertResultsType and grab the list of > > inserted feature ids? > > Yep, sounds like a reasonable solution. Mind though, not all stores will > give you back a valid id. If you do transactions on shapefiles _I believe_ > you won't get back a valid id (might be wrong, but I remember those > giving back ids like "new0", "new1" and so on). yup, that's what shapefile does... for my use case I'm going to have to limit to stores that provide steady fids anyways. As a side note, iirc, arcview used to use a special shapefile field for ids, and I wonder if we could at some point make it so that what attribute is the fid is configurable, as well as whether it's user provided or system generated (uuid would be the easier, some kind of numeric sequence a bit harder). > > > And in the process may be also remove the > > TransactionEventType.POST_INSERT constant as it looks it's not used > > anywhere and it's confusing for it to be there? > > POST_INSERT event is fired by WFSV rollback operation, so please > don't remove it. As for the recent WPS build breakage due to changes in the > WFS SHAPE-ZIP it would be good if you could load all of the projects > in the release > when making code analysis, and do a build with -Prelease before committing. > Extension modules are less important, yet they still are in the build and the > release so we should take them into account when making changes. of course.
Cheers, Gabriel > > Cheers > Andrea > > -- Gabriel Roldan [email protected] Expert service straight from the developers ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
