On Tue, Jun 7, 2011 at 6:01 AM, Ben Caradoc-Davies <[email protected]> wrote: > (1) Add xalan as a compile dependency of GeoTools gt-app-schema. This is > nasty: the dependency is being added because of the behaviour of a > consumer of gt-app-schema that GeoTools should not know about. In my > view, this would put the dependency in the wrong place. > > (2) Add xalan as a compile dependency of GeoServer wfs. This makes sense > to me, because wfs is the thing doing the transforming. We could leave > xalan out of release/bin.xml and put it in release/ext-app-schema.xml so > it is shipped with the app-schema plugin. This oddity should be > documented in wfs/pom.xml and release/bin.xml. But then, what about the > war? Will xalan be included in geoserver.war if we do this? > > (3) Add xalan as a dependency of the release module. > > What do you recommend?
I'd got for (1), the reasoning is not about dependencies imho, it's about working vs not working. Pure wfs work fine without the Xalan baggage, so it makes no sense to add the extra load only because there is one unused code path that depends on it. Put the extra load where the extra load is due, in the app-schema module that is the reason of that dependency. See also my other mail about using built-in JDK xpath/xslt features, maybe you can rework your xpath expression to just work against the jdk 5 xpath/xslt abilities Cheers Andrea -- ------------------------------------------------------- Ing. Andrea Aime GeoSolutions S.A.S. Tech lead Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.youtube.com/user/GeoSolutionsIT http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ------------------------------------------------------- ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
