Ah, forgot to mention this. Would it be possible to create a squashed merge or at least to divide the patch in a small bunch of commits? that's what I do when working on a large branch, having a ton of commits on the branch and then merge back as few commits as possible. You can do that with git merge --squash.
TIA, Gabriel On Tue, Nov 29, 2011 at 1:59 PM, Gabriel Roldan <[email protected]> wrote: > Hi Jim, > > that is great news, thanks for the continued effort. > > redirecting to geowebcache-devel mailing list. > > I do have time to review this week, and am about to pull locally now > and do that. > > As we don't have a concept of community modules or extensions so far > in gwc, in order to merge into master asap I would ask that this > functionality (the job manager) is not enabled by default, but needs > to be enabled through an env variable (like we do to disable the > metastore, etc) for some time until we feel it's strong enough as to > be on by default. > Rationale is that both stable and trunk versions of geoserver depend > on the same gwc version and we'll need to release soon in order for > the stable geoserver version to be released against a gwc release, and > this is a very extensive change. I hope I'll be able of commenting > better once I do the code review, but essentially I'm ok with merging > if we can make the use of the database for the job managed an opt in > option for the time being. Also because at some point we may need to > catch up and see how all this fits on the longer term plans for gwc > wrt scalability and clustering and probably we'll need to port the > database code to another type of storage and make sure it works > properly on a cluster environment. > > Best regards, > Gabriel > > On Sun, Nov 27, 2011 at 8:21 AM, Jim Groffen <[email protected]> wrote: >> Hello Gabriel, lists >> >> >> >> The pull request for the job management features for GeoWebCache at >> https://github.com/GeoWebCache/geowebcache/pull/62 is now good to go. >> >> >> >> I’ve generated a JIRA in GeoServer >> https://jira.codehaus.org/browse/GEOS-4882 with diff files attached. These >> add the gwc-client jar as a dependency and update GWC.java and some of the >> spring config for GeoWebCache so that the job management system works in >> GeoServer as well as GeoWebCache. >> >> >> >> This contribution has been mainly going on in the GeoWebCache project. If >> you are interested in the functionality have a look at >> https://github.com/lisasoft/geowebcache/wiki/Job-Manager-for-GeoWebCache - >> included are improvements to the restful interface and a rich web client for >> managing seeding tasks as jobs that can be scheduled etc. >> >> >> >> I’ve done a bunch of testing on this and am keen to get this contributed. >> I’m hoping there is more time to improve on this work and getting it onto >> trunk is going to really help me get that time. >> >> >> >> Any comments / feedback please send it my way – I’m keen to hear it. >> >> >> >> Thanks for all your help Gabriel. >> >> >> >> Jim Groffen. >> >> >> >> LISAsoft >> >> Level 1, 30 Currie St >> >> Adelaide SA 5000 Australia >> >> PO Box 8118 Adelaide SA 5001 >> >> >> >> PH: +61 8 8425 8050 >> >> MOB: +61 439 780 969 >> >> >> >> >> ________________________________ >> The contents of this email are confidential and may be subject to legal or >> professional privilege and copyright. No representation is made that this >> email is free of viruses or other defects. If you have received this >> communication in error, you may not copy or distribute any part of it or >> otherwise disclose its contents to anyone. Please advise the sender of your >> incorrect receipt of this correspondence. > > > > -- > Gabriel Roldan > OpenGeo - http://opengeo.org > Expert service straight from the developers. -- Gabriel Roldan OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
