On Thu, Jan 5, 2012 at 7:03 PM, Justin Deoliveira <[email protected]>wrote:

> Resource wise things work like this: if a resource path is relative the
>> SLDParser will assume it's relative to the
>> location of the .sld file and will try to build that path, which will in
>> turn replace the original path in the
>> in memory reprentation of the style.
>> See SLDParser line 1662 (be seated and prepared, that code is ugly).
>>
>> Right, makes sense though. The issue is moving the style to
> a different workspace, the external graphics will be left behind as things
> sit today.
>

I agree, but I'm not sure that making the resources into explicit
configuration items will make things better.

The user does not have to manually declare them, so we'd have to extract
their location automatically anyways
each time the SLD (or css) is saved.

Given that, isn't it better to do the job only when the files are moved, if
they are at all?
We could have a flag that disables the automatic path transformation during
parsing, we walk the style, get
the resource references, and locate the relative ones, either moving them
around or updating the
references.

I would actually go for the latter, unless you first want to check all the
styles around to see if any other
style also depends on the same resource (in such case you cannot move it,
you have to copy it instead)

Cheers
Andrea

-- 
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy

phone: +39 0584 962313
fax:      +39 0584 962313
mob:    +39 339 8844549

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to