On Fri, Jun 15, 2012 at 9:13 AM, Andrea Aime
<[email protected]>wrote:
> On Fri, Jun 15, 2012 at 5:06 PM, Justin Deoliveira <[email protected]>
> wrote:
> >> However some setup only a handlful of types skipping the whole data dir
> >> setup, so we need to be able to recognize if a test is setting up the
> base
> >> data dir or not. Many tests add on top of it, but that's something we
> can
> >> handle after having setup the precanned one right?
> >
> >
> > When I did this locally i sort of ditched the pre-canned idea and just
> build
> > up the resources programatically like we do now, just with the new
> > structure. It was actually quite easy, just create a local catalog
> instance,
> > attach a persister to it and start populating it.
>
> Works for me
>
>
> >> Eclipse wise there is a decent plugin for TestNG, thought I'm not too
> >> happy about the way it works (maybe it's just a familiarity thing).
> >> Don't know about the build server.
> >
> > Yeah, i haven't tried the plugin at all. TestNG does seem to offer a lot
> > more options though. Of particular interest to me are test groups
> > and parallelism.
> >
> >>
> >> Regardless the switch to both JUnit 4 and TestNG would be a rather big
> >> task. I can help some during the weekend if we're going there, but
> >> it sounds like something that would require "all hands on board" to
> >> be carried out (plus probably a GSIP to vote the switch).
> >
> > A big task and proposal worthy indeed. At this point just something i am
> > doing some initial experimentation on brought about by the fact that
> doing
> > full test runs are pretty painful.
> >
> > As for how to migrate I am sort of thinking an incremental approach here.
> > Basically the idea would be come up with a new base test class that tests
> > would extend that implement the new testing setup. And port modules over
> it
> > to one-by-one.
>
> I'm on board with this, but wouldn't this prevent a switch to TestNG or
> Junit 4?
> That is, how does one have a base class that works both for JUnit 3
> and Junit 4/TestNG,
> leaving the existin tests untouched?
>
The idea is that the existing base would remain a junit3 style, and the new
one would be based on junit4 (if we go that way). So basically first step
would be to upgrade codebase to junit 4 which shouldn't affect anything,
the old style tests will still run without issue.
Then when someone goes to port a test case over the workflow is basically:
1. Switch to the new base class (designed to be a pretty seamless drop in
replacement)
2. Annotate all test methods
Note that TestNG actually would make this easier in this regard, it allows
you to annotate the class itself with a "@Test" annotation and when that
happens it basically treats every public method as a test case.
>
> Another possibility could be to have our JUnit 3 base class process
> annotations and
> handle them accordingly (ok, not nice, but probably less work)
>
> Cheers
> Andrea
>
> --
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
>
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
>
> phone: +39 0584 962313
> fax: +39 0584 962313
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
