Ha, you beat me to it Ben. Was just going to mention that our current
policy for pull requests is to file a jira alongside a pull request so devs
get the notification. However, I think i found the reason why we are not
getting notified and its described here:
http://alexking.org/blog/2011/11/28/not-getting-github-notifications
Myself, yourself, Andrea, and Jody were in the owners group and not the
individual team groups. I figured one encompassed the other but i guess not
when it comes to notifications. I confirmed with Gabriel that he does
indeed get the pull request notifications.
So I wonder... do we still need a jira to accompany a pull request? I am
tempted to say no since it would seem to be needless overhead but there is
the downside of the changelog not containing such patches. Tough call.
Interested in hearing what other folks think.
On Tue, Jul 10, 2012 at 7:43 PM, Ben Caradoc-Davies <
ben.caradoc-dav...@csiro.au> wrote:
> Pull requests are a separate issue (mentioned at Monday's meeting).
> Possibly because GeoServer is a GitHib organisation, nobody gets
> notified about pull requests (I have heard mixed reports between GT and
> GS).
>
> Have you created a GEOS Jira issue for the pull request? This might be
> the most robust and traceable process.
>
> Anyone have a best-practice to recommend?
>
> On 11/07/12 08:32, David Winslow wrote:
> > Anyway, I ended up more time than seems necessary because of some
> > exceptions being silently swallowed in GeoTools code. I issued a pull
> > request against the new Github repo:
> > https://github.com/geotools/geotools/pull/3
> > I also made a patch against GeoServer. Even though it wasn't causing my
> > failure, it seems like there are some places in GeoServer where we rely
> > on a directory containing a single image being used as a single-tile
> > imagemosaic instead of using a more specific coveragestore. I think it
> > makes things a bit cleaner to use the more specific type where it's
> > known: https://github.com/geoserver/geoserver/pull/4
>
> --
> Ben Caradoc-Davies <ben.caradoc-dav...@csiro.au>
> Software Engineer
> CSIRO Earth Science and Resource Engineering
> Australian Resources Research Centre
>
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
