On Fri, Aug 10, 2012 at 6:43 PM, Justin Deoliveira <[email protected]>wrote:
> The process group is really just a reference to a factory, a flag that
>> enables/disables it, and a list
>> of disabled processes:
>>
>> https://github.com/aaime/geoserver/blob/wps-filter/src/extension/wps/wps-core/src/main/java/org/geoserver/wps/ProcessGroupInfo.java
>>
>
>
> Also, a minor nit-picky think I see that the public modifier is used
> sometimes on interfaces and sometimes not... be nice to be consistent. I
> tend to leave them off since its redundant.
>
Sure, I can fix that.
>
>> Here is some screenshots from the GUI. The main entry point in the WPS
>> admin page:
>>
>> [image: Inline image 1]
>>
>
> Perhaps a title for this section like "Process groups" might mean more to
> users than "Process filtering directives"... or maybe just "Process
> filtering". Also where do the group descriptions come from? Are they
> configurable or somehow derived from the factory. It would be nice if the
> description made consistent use of case.
>
They are coming directly from the factory, so the code needs to be modified
in order to get what you want.
As far as I can see ModificationProxy simply clones collections, that takes
>> care of adding/removing
>> items, but not modifying them.
>> I see there are lists that do wrap their contents too, used for the
>> methods that return lists of info objects
>> from the catalog, but they are not used inside ModificationProxy "get"
>> property paths.
>> So far the cloning works good, but it made me wrestle with the code quite
>> a bit before discovering
>> where the issue was (I was blaming Wicket, for once it wasn't it :-p )
>>
>
> Hmmm... indeed this seems like a hole and happens in cases where an object
> needs to return a mutable list. The ProxyList is only suitable for
> immutable lists... it would be nice to handle this in ModificationProxy and
> have it return not just a cloned collection but a cloned collection that
> also proxies the objects in the collection. Rather than have a mix of
> cloning and proxying going on.
>
Indeed. Being a bit short on time I went the cloning route, changing the
modification proxy can lead to unexpected issues
in other areas, and for the time being I managed to get things going with a
handful of lines of code, but I agree the
ModificationProxy needs to be fixed.
http://jira.codehaus.org/browse/GEOS-5264
Btw, the issue is not on wheter the list is mutable or not
(addition/removal is handled properly) but wheter the
contents of the list are mutable or not.
Wondering if the modification proxy should be informed with an annotation,
or should just try to wrap whatever
list contents are found.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
