Hi Justin, I'm looking at the code...
> From a pure WMS request standpoint the format options are the correct > way. But the kml reflector is meant purely for convenience, so using > the parameters as kvp in the request makes sense. So i would say that > having the KML reflector (or some other reflector) support direct > options and translate them into the format_options parameter for the > reflecting request it is generated is ok. Does that make sense? It may cause some confusion in users and add unnecessary logic on my point of View. I see that most of the methods for the kvp parameters are deprecated into the WMSGetMapRequest saying: @deprecated use <code>getFormatOptions().get( "legend" )</code> All of those methods are unused except than getLegend() used into the KMLTransformer.encode() method. Do you think that we have to continue supporting those options as kvp? My intention was to: - remove deprecated use of getLegend from KMLTransformer.encode() method using the format_options - fix documentation porting deprecated (and not used getters) options under the format_options section. - align the GEOS-5332 fix to the new changes. If this is not the case and you think that we have to continue supporting those deprecated options, the parameters specified in format_options may override those specified as kvp mode? If is this the case, can these changes be backported to the 2.2.1 release ? Sorry but I want to close this issue ASAP (in the best way). Thank you, Carlo > > On Tue, Oct 16, 2012 at 7:00 AM, Carlo Cancellieri > <[email protected]<mailto:[email protected]>> wrote: > > Hi all, > I'm going to complete this fix but I'm in doubt on how to use some > vendor parameters: > > Looking here: > http://docs.geoserver.org/latest/en/user/services/wms/vendor.html > > I see that KMSCORE and KMATTR may be specified as normal parameters > &Kmscore=100&kmattr=... > > The kml reflector instead uses those parameters into format_options: > > <href><![CDATA[http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false;KMPLACEMARK:false;KMSCORE:40;KMATTR:true;&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]<http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false%3bKMPLACEMARK:false%3bKMSCORE:40%3bKMATTR:true%3b&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1%5d>]></href> > > > What's the correct way? Are there any other vendor parameters which > should be moved under format_options? (so I could fix documentation). > > Thank you, > Carlo > > ________________________________ > > Date: Wed, 3 Oct 2012 11:32:36 -0500 > > From: [email protected]<mailto:[email protected]> > > To: > [email protected]<mailto:[email protected]> > > > Subject: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not > > include sld and vendor parameters into the request > > > > > [https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr%2fTscmysv4%3d0&url=http%3a%2f%2fwww.codehaus.org%2fcodehaus-small.gif<https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr/Tscmysv4%3d0&url=http://www.codehaus.org/codehaus-small.gif>] > > > [https://jira.codehaus.org/secure/useravatar?avatarId=10232] > > carlo > > > cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri> > > > created [Bug] GEOS-5332<https://jira.codehaus.org/browse/GEOS-5332> > > KMLTransformer does not include sld and vendor parameters into the > > request<https://jira.codehaus.org/browse/GEOS-5332> > > > > > > > > Issue Type: [Bug] Bug > > Affects Versions: 2.2.x, 2.3-beta1 > > Assignee: Andrea > > Aime<https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime> > > Created: 03/Oct/12 11:31 AM > > Description: > > > > when using a request like the following: > > http://localhost:8080/geoserver/ows? > > service=WMS&request=getMap&version=1.1.1 > > &layers=sf:7416_eto01 > > &cql_filter=gaez_id='lr_soi_hwsd_domi' > > &bbox=-180,-90,180,90 > > &width=256&height=256&transparent=true > > &sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136 > > &srs=EPSG:4326 > > &format=application/vnd.google-earth.kml+xml > > > > I obtain a kml without the sld into the wms request, this also happens > > for some of the vendor parameters. > > > > > > Fix Versions: 2.2.1 > > Project: GeoServer<https://jira.codehaus.org/browse/GEOS> > > Priority: [Major] Major > > Reporter: carlo > > > cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri> > > > > > > > > > This message is automatically generated by JIRA. > > If you think it was sent incorrectly, please contact your JIRA > > > administrators<https://jira.codehaus.org/secure/ContactAdministrators%21default.jspa>. > > > For more information on JIRA, see: http://www.atlassian.com/software/jira > ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
