Okay so I am going to conclude that we go with Justin's proposal to put the internal store in to core. The other thing is, should I keep its name or rename it to DefaultCatalogStore?

Regards
Niels

On 12/07/2012 05:50 PM, Andrea Aime wrote:
On Fri, Dec 7, 2012 at 2:30 PM, Niels Charlier <[email protected] <mailto:[email protected]>> wrote:


        Could the current work be committed, so that we can have a
        look at it?


    https://github.com/NielsCharlier/geoserver.git
    branch: cswpublic


So yeah, looking at the sources I believe all the support for ISO records should be moved into csw-api anyways, allowing others to build stores that generate ISO records.
Basically this package:
https://github.com/NielsCharlier/geoserver/tree/cswpublic/src/community/csw/csw-internal-store/src/main/java/org/geoserver/csw/records/iso
This one too, should probably be part of csw-core (since it deals with the procotol, instead of the record concept per se):
https://github.com/NielsCharlier/geoserver/tree/cswpublic/src/community/csw/csw-internal-store/src/main/java/org/geoserver/csw/response/iso

This would leave the pure catalog in this module, which is indeed not big:
https://github.com/NielsCharlier/geoserver/tree/cswpublic/src/community/csw/csw-internal-store/src/main/java/org/geoserver/csw/store/internal

I still think that having the store in its own module would look better (do we have any default datastore or coveragestore in GeoServer? even the ones used by core can be plugged out), but I'm not opposed to seeing this get merged in as the default one like we did for the security subsystem.

I guess the difference is on whether is it normal to have a store 100% of the time in, with little
likeliness of being replaced by another, or not.
Right now it certainly seems like it will be most of the time in, but if we grow an implementation that can actually handle efficiently large number of records detached from the GS own
catalog things might change.

Cheers
Andrea

--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to