So, if the flag has a default value of false can be backported instead?

And what if I need to add an enum or string or something?

Thanks.

Mauro
Il 03/ott/2013 10:11 "Christian Mueller" <[email protected]>
ha scritto:

> Hi Mauro
>
> Another hint. You have to change the configuration object of this filter,
> please have a look at GeoServerSecurityManager, method migrateIfNecessary.
>  If you add some boolean flags and a flag has a default value of true, you
> have to
>
> 1) add migration code
> 2) Due to 1), it is not possible to backport to 2.4.x series.
>
> Christian
>
>
> On Wed, Oct 2, 2013 at 4:30 PM, Christian Mueller <
> [email protected]> wrote:
>
>> Nice improvement. Go ahead modifying the filter and dont forget to add
>> two check boxes on the configuration panel.
>>
>> Please ping me for a review of the patch.
>>
>> Christian
>>
>>
>> On Wed, Oct 2, 2013 at 3:59 PM, Mauro Bartolomeoli <
>> [email protected]> wrote:
>>
>>> Hi everybody,
>>> to implement authentication in Geoserver for a customer I would need to
>>> use the J2EEAuthenticationFilter to inherit the user from an Apache
>>> frontend, but also to assign roles to that user using a
>>> GeoServerRoleService (in particular a new one fetching roles from LDAP).
>>>
>>> Currently the J2EEAuthenticationFilter uses the GeoServerRoleService to
>>> get a list of all roles and then filters them using
>>> request.isUserInRole(<role>), but in my use case no roles are assigned by
>>> the frontend, so I would need to use service.getRolesForUser(username)
>>> instead, to let the GeoServerRoleService assign roles to recognized users.
>>>
>>> For this to be implemented I would need to
>>> change J2EEAuthenticationFilter a bit. I was thinking to add a
>>> configuration option to decide whether roles are taken from the container
>>> (as they are now, this could be the default), the GeoServerRoleService or
>>> both.
>>>
>>> What do you think?
>>> Can I proceed? Is there any other way to get this behaviour using the
>>> existing filters?
>>>
>>> Regards,
>>> Mauro
>>>
>>> --
>>>  ==
>>> Our support, Your Success! Visit http://opensdi.geo-solutions.it for
>>> more information.
>>> ==
>>>
>>> Dott. Mauro Bartolomeoli
>>> @mauro_bart
>>> Senior Software Engineer
>>>
>>> GeoSolutions S.A.S.
>>> Via Poggio alle Viti 1187
>>> 55054  Massarosa (LU)
>>> Italy
>>> phone: +39 0584 962313
>>>  fax:     +39 0584 1660272
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> -------------------------------------------------------
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> October Webinars: Code for Performance
>>> Free Intel webinars can help you accelerate application performance.
>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
>>> from
>>> the latest Intel processors and coprocessors. See abstracts and register
>>> >
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>>
>>
>>
>> --
>> DI Christian Mueller MSc (GIS), MSc (IT-Security)
>> OSS Open Source Solutions GmbH
>>
>>
>
>
> --
> DI Christian Mueller MSc (GIS), MSc (IT-Security)
> OSS Open Source Solutions GmbH
>
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to