I am also +1 on making the new encoder the default on master. I think a GSIP is required.
I appreciate Jody's caution about making brand new code the default for core functionality; in general, a gradual transition is a good practice. However: (1) this is only an implementation change and does not alter interface or formats, (2) the new implementation offers benefits to pure Java users, (3) making it the default on master makes adoption more likely, as non-default behaviour is often not tested, and (4) the timing (well before 2.5.0) is just great! If we were a month out, I would be resistant about making this the default on master, but this time scale will give it a decent test. Andrea also has support on the users list. I would be +1 to make the new encoder an option on master right now without a GSIP. Kind regards, Ben. On 25/11/13 23:59, Justin Deoliveira wrote: > No objection here to making it the default on trunk. Imo now is the best > time to do it, while we are in dev phase. > > > On Mon, Nov 25, 2013 at 3:28 AM, Jody Garnett <[email protected] > <mailto:[email protected]>> wrote: > > I would bee keen to see it land as an option in trunk. I would like > it if we could strike a balance between discussion and breaking out > a GSIP proposal. > > I do not see this change as particularly strategic, destabilising, > or as a scary API or UI change. It looks like exactly the kind of > RnD we expect on trunk and think we could proceed based on discussion. > > > > Jody Garnett > > > On Mon, Nov 25, 2013 at 4:34 AM, Andrea Aime > <[email protected] <mailto:[email protected]>> > wrote: > > Hi, > thinking about the new PNG encoder, I was wondering, what if I > make a GSIP to include it > on trunk as the default PNG encoder (so move the code in the wms > module), > replacing also the usual checkbox about choosing the > "native" PNG encoder with a combo box with a drop down having 3 > options, jdk, native > or PNGJ. > > Rationale: > * the new PNG encoder is pure java, requires no extra > installations, and provides both performance > and output size benefits > * has a good amount of testing, with checks it can encode more > color models than GeoServer > normally produces in output (all the ones contained in the > PNG spec) > * we still have three+ months ahead before the 2.5.0 release, so > there is time to kick its tires > * for any residual corner case the drop down choice will allow > admins to switch to another > encoder > > I understand this encoder is "new", but so were the new KML > module and the new shapefile > modules last release (so far it seems it went well for those > two, only a few issues were reported), > and that's precisely the reason for a GSIP. > > Just wanted to test the waters and see if anyone would be > strongly opposed to the move. > > Cheers > Andrea > > > -- > == > Our support, Your Success! Visit http://opensdi.geo-solutions.it > for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 <tel:%2B39%200584%20962313> > fax: +39 0584 1660272 <tel:%2B39%200584%201660272> > mob: +39 339 8844549 <tel:%2B39%20%C2%A0339%208844549> > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech > innovation. > Intel(R) Software Adrenaline delivers strategic insight and > game-changing > conversations that shape the rapidly evolving mobile landscape. > Sign up now. > > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > Geoserver-devel mailing list > [email protected] > <mailto:[email protected]> > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and > game-changing > conversations that shape the rapidly evolving mobile landscape. Sign > up now. > > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > _______________________________________________ > Geoserver-devel mailing list > [email protected] > <mailto:[email protected]> > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > > > > -- > *Justin Deoliveira* > Vice President, Engineering | Boundless > [email protected] <mailto:[email protected]> > @j_deolive <https://twitter.com/j_deolive> > > > ------------------------------------------------------------------------------ > Shape the Mobile Experience: Free Subscription > Software experts and developers: Be at the forefront of tech innovation. > Intel(R) Software Adrenaline delivers strategic insight and game-changing > conversations that shape the rapidly evolving mobile landscape. Sign up now. > http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk > > > > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Ben Caradoc-Davies <[email protected]> Software Engineer CSIRO Earth Science and Resource Engineering Australian Resources Research Centre ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
