Hi Niels,
I did some tests in geoserver with the latest code and it seems good so I
have merged your updates.
Thanks for your contribution.
Cheers,
Daniele
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Daniele Romagnoli
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Wed, Jan 29, 2014 at 3:21 PM, Daniele Romagnoli <
[email protected]> wrote:
> Hi Niels,
> I have reviewed the Pull request and it seems good to me.
> I'll do some testing with that code as soon as I can and I'll merge it
> when done.
>
> Thanks for your contribution.
> Cheers,
> Daniele
>
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
> information.
> ==
> Ing. Daniele Romagnoli
> Senior Software Engineer
>
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
>
> On Tue, Jan 28, 2014 at 8:33 PM, Simone Giannecchini <
> [email protected]> wrote:
>
>> Ciao Niels,
>> I had a cursory lokk at the changes and they seem to bring clarity as
>> well as doing some cleanup.
>>
>> I will ask daniele tomorrow to review and test the pull on all the the
>> raster plugins.
>>
>> Regards,
>> Simone Giannecchini
>> ==
>> Our support, Your Success! Visit http://opensdi.geo-solutions.it for
>> more information.
>> ==
>>
>> Ing. Simone Giannecchini
>> @simogeo
>> Founder/Director
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39 333 8128928
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>>
>> On Mon, Jan 27, 2014 at 6:16 PM, Niels Charlier <[email protected]> wrote:
>> > On 27/01/14 17:51, Andrea Aime wrote:
>> >> What's stopping you from overriding getOriginalEnvelope(String
>> >> coverageName)?
>> >> The reason why getOriginalEnvelope() (without the coverage name) was
>> >> kept was to avoid breaking all of the existing client code just for
>> >> the sake
>> >> of NetCDF.
>> >> If your implemetation does not have a shared original envelope you just
>> >> throw an unsupported operation exception for the moment, and find out
>> >> what works and what does not on top of it (there might still be code
>> >> around
>> >> that does not know about coverage names).
>> >> But... isn't this what we have now?
>> >>
>> > No, variables like 'crs' and 'originalEnvelope' are being used by the
>> > code. If they are left empty, you will get exceptions thrown when you
>> > try to load the data in geoserver.
>> >
>> > My suggestion is to replace the calls to these variables in the code by
>> > calls to the functions, which are indeed already in place.
>> >
>> >
>> > Regards
>> > Niels
>> >
>> >
>> ------------------------------------------------------------------------------
>> > CenturyLink Cloud: The Leader in Enterprise Cloud Services.
>> > Learn Why More Businesses Are Choosing CenturyLink Cloud For
>> > Critical Workloads, Development Environments & Everything In Between.
>> > Get a Quote or Start a Free Trial Today.
>> >
>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
>> > _______________________________________________
>> > Geoserver-devel mailing list
>> > [email protected]
>> > https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
>
>
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
