On Thu, Jun 12, 2014 at 4:17 PM, Justin Deoliveira <
[email protected]> wrote:
> That said, these cases seems relatively unlikely, I would just point out
>> these issues in the special exception javadoc
>> and make this the implementors responsibility (after all, any code using
>> the existing
>> HttpErrorCodeException is in the same boat, using it in a normal pre OWS
>> 2.0 service will result in a spec violation too,
>> not only we don't use valid codes anymore, we don't build a service
>> exception at all... btw, we should probably amend the
>> javadoc of that exception too to clarify this).
>>
>
> Not sure if HttpErrorCodeException is a good precedent since afaik it
> isn't really used in error cases. The only usages of it I see are for KML
> for empty regions, which doesn't really work like in a typical OGC context,
> and for Caching WMS to send back a Not Modified, which isn't an error case.
>
My point was, it's there, and it can be abused in any way by implementors
(process ones too).
>
> When you say leave it up to the implementor to deal with how would that
> look if they wanted to throw back the right exception for the service? They
> would to have to retype the exception to another type?
>
They would have to build a specific subclass that implements the marker
interface.
That said.. where is it that we are actually recognizing the exceptions
that way? Like, in WMS we throw only ServiceException, there is no such a
thing as
WMSException, and where we have it, are we really making use of it, or is
it more just a convention that we adopted?
When Gabriel refactored the hell out of WMS he dropped WMServiceException
under the notion that is was useless... I was not too happy at the time,
but indeed I cannot say I've ever needed a special subclass for it.
>
> Anyways, it would be nice to hear from others with an opinion. And since
> we are talking of potential spec breaking I am thinking a GSIP may be in
> order.
>
Yep, let's hear from others
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
