Since this is a core change do you mind writing a proposal first so we can
talk through the api structure before you start coding?
On Thu, Oct 9, 2014 at 1:03 AM, Christian Mueller <
[email protected]> wrote:
> Yes, it will be added to restconfig. I want to it the same way as I did for
>
> http://docs.geoserver.org/stable/en/user/rest/api/masterpassword.html
>
> 1) Open a JIRA issue
> 2) Preparing a pull request containing core code, test code and the
> documentation (API,examples)
> 3) Waiting for comments (2 weeks)
> 4) Merge the pull request
>
> Cheers
> Christian
>
>
>
> On Wed, Oct 8, 2014 at 4:25 PM, Justin Deoliveira <
> [email protected]> wrote:
>
>> Are you going to be adding this to restconfig? If so definitely a jira
>> and probably a proposal.
>>
>>
>> On Wed, Oct 8, 2014 at 8:16 AM, Christian Mueller <
>> [email protected]> wrote:
>>
>>> Thanks for the input, will use POST for adding and PUT for editing.
>>>
>>> Should I open a JIRA issue ?
>>>
>>> Cheers
>>> Christian
>>>
>>>
>>>
>>> On Wed, Oct 8, 2014 at 3:24 PM, Justin Deoliveira <
>>> [email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Wed, Oct 8, 2014 at 5:23 AM, Christian Mueller <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Mauro
>>>>>
>>>>> Sounds reasonable. To summarize:
>>>>>
>>>>> The GET method fetches all rules.
>>>>>
>>>>> The DELETE method deletes one or more specific rules, if only one
>>>>> specified rule does not exist, the request is ignored and an error is
>>>>> returned.
>>>>>
>>>>> The PUT method adds/updates one more specific rules.
>>>>>
>>>>
>>>> I following RESTful practices use POST for adding a new rule and PUT
>>>> just for editing an existing one.
>>>>
>>>>>
>>>>> Does this cover your idea ?
>>>>>
>>>>> Cheers
>>>>> Christian
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 8, 2014 at 12:46 PM, Mauro Bartolomeoli <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Christian,
>>>>>> in my opinion a more granular access to the single rules would be
>>>>>> more usable.
>>>>>>
>>>>>> I think the REST API should allow CRUD access to the rules, and apart
>>>>>> from the fetch (Read), where it is useful to get all the rules at once
>>>>>> (some support for pagination would be helpful, but not mandatory), the
>>>>>> Create, Update and Delete operations would be better implemented (from a
>>>>>> client-side point of view) rule by rule.
>>>>>>
>>>>>> In general, now the rules are stored on property files, but having
>>>>>> them on a different storage (like we already support for the Catalog) in
>>>>>> the future would be nice (for clustering support and so on), and a bit
>>>>>> more
>>>>>> abstract REST API would be ready for that.
>>>>>>
>>>>>> Just my 2 cents.
>>>>>>
>>>>>> Mauro
>>>>>>
>>>>>> 2014-10-08 12:02 GMT+02:00 Christian Mueller <
>>>>>> [email protected]>:
>>>>>>
>>>>>>> Hi all
>>>>>>>
>>>>>>> Maybe I have mandate to add the REST API for access control. The
>>>>>>> rules are stored in
>>>>>>>
>>>>>>> rest.properties
>>>>>>> layers.properties
>>>>>>> services.properties
>>>>>>>
>>>>>>> All these files are simple java property files. Supported formats
>>>>>>> for the REST API:
>>>>>>>
>>>>>>> XML using the Java XML property file syntax
>>>>>>> JSON (will have to investigate)
>>>>>>>
>>>>>>> The idea is to use HTTP GET to fetch the content of a file and HTTP
>>>>>>> PUT to rewrite the whole file.
>>>>>>> The comments in the files will be untouched.
>>>>>>>
>>>>>>> If this is ok I will open a JIRA issue.
>>>>>>>
>>>>>>> Opinions ?
>>>>>>>
>>>>>>> Cheers
>>>>>>> Christian
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> DI Christian Mueller MSc (GIS), MSc (IT-Security)
>>>>>>> OSS Open Source Solutions GmbH
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------------------
>>>>>>> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
>>>>>>> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS
>>>>>>> Reports
>>>>>>> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
>>>>>>> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
>>>>>>>
>>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
>>>>>>> _______________________________________________
>>>>>>> Geoserver-devel mailing list
>>>>>>> [email protected]
>>>>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> DI Christian Mueller MSc (GIS), MSc (IT-Security)
>>>>> OSS Open Source Solutions GmbH
>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
>>>>> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS
>>>>> Reports
>>>>> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
>>>>> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
>>>>>
>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
>>>>> _______________________________________________
>>>>> Geoserver-devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Justin Deoliveira
>>>> VP Engineering | Boundless <http://boundlessgeo.com/>
>>>> [email protected]
>>>> @boundlessgeo <http://twitter.com/boundlessgeo/>
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> DI Christian Mueller MSc (GIS), MSc (IT-Security)
>>> OSS Open Source Solutions GmbH
>>>
>>>
>>
>>
>> --
>> Justin Deoliveira
>> VP Engineering | Boundless <http://boundlessgeo.com/>
>> [email protected]
>> @boundlessgeo <http://twitter.com/boundlessgeo/>
>>
>>
>>
>
>
> --
> DI Christian Mueller MSc (GIS), MSc (IT-Security)
> OSS Open Source Solutions GmbH
>
>
--
Justin Deoliveira
VP Engineering | Boundless <http://boundlessgeo.com/>
[email protected]
@boundlessgeo <http://twitter.com/boundlessgeo/>
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
