On Fri, Jan 23, 2015 at 8:45 PM, Kevin Smith <[email protected]>
wrote:
> I've found two sources of non-daemon thread pools that aren't being shut
> down properly.
>
> https://jira.codehaus.org/browse/GEOS-6850
>
> One is in GuavaAuthenticationCacheImpl, the other in FileSystemWatcher
> used to provide update notification for the FileResourceStore.
>
> The simple solution would be to toss in a ThreadFactory to make them
> daemon threads so they don't hold up VM shutdown.
>
> Shutting them down properly though would be preferable.
> GuavaAuthenticationCache would be fairly simple to make a DisposableBean
> but FileResourceStore is not.
>
DisposableBean is the way to go. As for FileSystemWatcher, the javadoc says:
" * This implementation currently polls the file system and should be
updated with Java 7 WatchService when available. The internal design is
similar
* to WatchService, WatchKey and WatchEvent in order to facilitate this
transition."
We are on Java 7 now so... time to upgrade?
> One thing that comes to mind is adding a method to GeoServerExtension to
> register a DisposableBean that was not instantiated as a spring bean to be
> disposed of on context shutdown. Any thoughts on this?
>
Does not seem the right place, has nothing to do with "extensions"
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
