On 20-05-15 11:01, Andrea Aime wrote: > Not against it, but since it will create a ton of "tech debt", we need > a proposal > and all devs to agree that from now all new restlets are going to be > written > with Spring. > Also, how do you intend to keep the rest-config module working with > a mix of the two systems, can actually gradually migrate, or would > we have to rewrite all restconfig in a single shot?
The idea would be to have them next to each other for now. See below. > GeoServer heavily relies on XStream for that task, is this > another technology you're proposing as a replacement for the future? > I see that spring-oxm can use XStream, but does not look like it's the > recommended way, can you clarify? Oxm is the integrated system used by the spring rest. You only add some annotations and spring takes care of everything, you can use the objects as input and output for your controllers without explicitly doing any conversion. There is a way to bridge the two systems: http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/oxm/xstream/XStreamMarshaller.html. The only non-recommendation regards security vulnerability when reading external sources, I'm not sure if that applies for us. Alternatively, we can migrate the concerned classes by adding annotations. > I'm not particularly thrilled by either options... yes, I agreed with > using spring rest, > but that was for the geofence rules api, which is completely separate, > I did not know you were also working on a user/role one, nor did you > mention spring-ox. > > As long as we can keep the new rest api separate I don't see a problem, > but I doubt you'll get any traction with a separate restconfig-ng > module, looks > like a big-bang rewrite is needed to make it actually replace the core > rest-config, > as I believe we need to keep everything config related in a single url > tree (the resources > are interconnected with each other), like, if we add a new type of > ResourceInfo (one based > on processes for example), we cannot really publish it in a different > rest url tree... it seems > to me only rest api that is not related to service and data config > could be moved to a > restconfig-ng, which would make it no config at all... > > But maybe you though it out in detail and see a way to make it work, > so please elaborate > I see your point. I think it should be possible to create a SimpleUrlHandlerMapping that handles specific mappings on the same url tree and is checked before the general restlet one. Alternatively, the current restlet dispatcher may be extended to forward requests to spring controllers. Regards Niels ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
