Hi Mauro I am fine with the regular expression. However, the GUI filter chain tester should work otherwise configuration becomes complicated.
Cheers Christian On Wed, Jun 17, 2015 at 6:57 PM, Mauro Bartolomeoli < [email protected]> wrote: > Hi, > I have almost finished adding query string matching to filter chains. > During the work I decided to change things a little bit in respect to the > original plan. > > Basically: > 1) I removed the flag for query string matching > 2) to specify query string matching, a regular expression needs to be > added to an existing ANT pattern; I tried to use this syntax: > > <Path ANT Pattern>|<Query String Regular Expression> where |<Query String > Regular Expression> is optional (if not specified the old matching > behaviour is used). The pipe separator can be changed if anyone has > different preferences. > > An example of complete pattern: > /wms/**|.*format=image/png.* > > > I think using the full regular expression syntax for the query string > matcher is better, since we have more expressive power, but we can also > choose to implement a simpler syntax with only the * and ? wildcards > accepted. Any thoughts? > > Thanks > Mauro Bartolomeoli > > > 2015-06-14 11:00 GMT+02:00 Christian Mueller < > [email protected]>: > >> Hi Mauro >> >> Sounds good to me, I had the same idea some time ago. >> Is it possible for you to fix the bug with the filter chain tester. >> >> Cheers >> Christian >> >> On Fri, Jun 12, 2015 at 6:51 PM, Mauro Bartolomeoli < >> [email protected]> wrote: >> >>> Hi, >>> following up https://osgeo-org.atlassian.net/browse/GEOS-7059 I think >>> it would be useful to allow filter chains pattern matching to also work >>> (optionally) on the query string (for example to have a different set of >>> filters for different output formats, like in the JIRA example). >>> >>> It should not be too difficult. My plan is to: >>> >>> 1) add a new flag to RequestFilterChain (matchQueryString), defaulted to >>> false >>> 2) extend Spring Security AntPathRequestMatcher to allow matching a >>> request url that contains the query string (currently only path info is >>> checked) >>> 3) use the extended AntPathRequestMatcher for chains >>> where matchQueryString is true (in GeoServerSecurityFilterChainProxy) >>> 4) extend the Wicket UI with a checkbox for the new flag >>> >>> Regards, >>> Mauro Bartolomeoli >>> >>> -- >>> == >>> GeoServer Professional Services from the experts! Visit >>> http://goo.gl/it488V for more information. >>> == >>> >>> Dott. Mauro Bartolomeoli >>> @mauro_bart >>> Senior Software Engineer >>> >>> GeoSolutions S.A.S. >>> Via Poggio alle Viti 1187 >>> 55054 Massarosa (LU) >>> Italy >>> phone: +39 0584 962313 >>> fax: +39 0584 1660272 >>> >>> http://www.geo-solutions.it >>> http://twitter.com/geosolutions_it >>> >>> ------------------------------------------------------- >>> >>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >>> >>> Le informazioni contenute in questo messaggio di posta elettronica e/o >>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >>> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >>> darcene notizia via e-mail e di procedere alla distruzione del messaggio >>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >>> principi dettati dal D.Lgs. 196/2003. >>> >>> >>> >>> The information in this message and/or attachments, is intended solely >>> for the attention and use of the named addressee(s) and may be confidential >>> or proprietary in nature or covered by the provisions of privacy act >>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >>> Code).Any use not in accord with its purpose, any disclosure, reproduction, >>> copying, distribution, or either dissemination, either whole or partial, is >>> strictly forbidden except previous formal approval of the named >>> addressee(s). If you are not the intended recipient, please contact >>> immediately the sender by telephone, fax or e-mail and delete the >>> information in this message that has been received in error. The sender >>> does not give any warranty or accept liability as the content, accuracy or >>> completeness of sent messages and accepts no responsibility for changes >>> made after they were sent or for other risks which arise as a result of >>> e-mail transmission, viruses, etc. >>> >>> >>> ------------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Geoserver-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >>> >> >> >> -- >> DI Christian Mueller MSc (GIS), MSc (IT-Security) >> OSS Open Source Solutions GmbH >> >> > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Dott. Mauro Bartolomeoli > @mauro_bart > Senior Software Engineer > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > -- DI Christian Mueller MSc (GIS), MSc (IT-Security) OSS Open Source Solutions GmbH
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
