Agreed, we have several classes that have been responsible for the same
story - gathering these methods into GeoServerResourceLoader is where I
want to go as well.
One great thing the work you have done (and Devon's change here) is code
can be consistently injected with "resourceStore" bean and they will get
the correct/configured implementation. So we should be able to reduce
GeoServerResourceLoader still further (down to the few bits of code that
need to look up a log file or a shapefile on disk.)
--
Jody Garnett
On 23 February 2016 at 01:04, Niels Charlier <[email protected]> wrote:
> On 23-02-16 06:53, Jody Garnett wrote:
>
> Some comments supplied for 510.
>
> - Removed ResourceStore interface from GeoServerDataDirectory where it
>> wasn't really being used. I got the impression from Jody that this whole
>> class might be heading towards deprecation anyway (correct me if I'm
>> wrong). There are a lot of deprecated methods in it.
>>
>
> I was hoping that by implementing ResourceStore it would be easier for
> code to make the transition from File use to Resource use.
>
> I believe that was the case, and Niels has done a lot of the transition in
> the last year. With the transition complete GeoServerDataDirectory indeed
> be offering reduced functionality.
>
>
> The remaining logic could be moved to GeoServerResourceLoader. I don't see
> a reason to have two middle men.
>
> Regards
> Niels
>
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
