Hi,
I don’t have direct experience with this product, but our company has the
Checkstyle and PMD checks implemented through our check-in process with Stash.
Sputnik does seem to be free for public repositories.
Speaking strictly for myself:
1. The initial period after adding the tools makes human readable pull
requests a little more difficult as the PMD and Checkstyle add comments to
every line they find against defined styles and “acceptable” coding practices.
a. E.g.
String my_variable = “SomeThing”;
String my_other_variable = “SomeThing”;
String my_last_variable = “SomeThing”;
String my_forgot_to_add_variable = “SomeThing”;
Generates a message on each line indicating that private variables should not
have underscores in them. Makes reading the code a little more difficult.
2. There needs to be buy-in or at least resignation to use :) the styles
that are enforced via the tools. Once the initial set of required changes are
made to be in compliance, the tools help maintain a consistent style across the
codebase.
If the styles are available publicly for setup, then tools such as IntelliJ ™
can run the identical checks on change sets before pushing to the main
repository.
My $.04
Chris Snider
Senior Software Engineer
Intelligent Software Solutions, Inc.
[Description: Description: Description: cid:[email protected]]
From: Andrea Aime [mailto:[email protected]]
Sent: Sunday, April 24, 2016 1:15 AM
To: Geoserver-devel <[email protected]>
Subject: [Geoserver-devel] Stumbled into a continuos code review tool
Hi,
just stumbled into this one:
https://sputnik.ci/
Looks like it would apply automatic code reviews to pull requests... sounds
tempting, although I guess it might be annoying for a while, not sure
the thing can review just the changed lines...
Experiences, opinions?
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i
file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo
è consentito esclusivamente al destinatario del messaggio, per le finalità
indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne
il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di
procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte,
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse,
costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the
attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act (Legislative
Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in
accord with its purpose, any disclosure, reproduction, copying, distribution,
or either dissemination, either whole or partial, is strictly forbidden except
previous formal approval of the named addressee(s). If you are not the intended
recipient, please contact immediately the sender by telephone, fax or e-mail
and delete the information in this message that has been received in error. The
sender does not give any warranty or accept liability as the content, accuracy
or completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of e-mail
transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
