Hi Andrea,
That coud work in my case, but i cannot see the wool graph, my opinion is that
in oracle type DataStore, this name collision check is useless because, in
Oracle you cannot have UID type Object names (e.g
8cddb91e-c522-4134-b6ae-24443c4dc9c0) so that collision is never happening.
so this check should be run only if info.store.type not equal Any oracle type
datastore )
Cheers
Attila
Feladó: [email protected] [mailto:[email protected]] Meghatalmazó
Andrea Aime
Küldve: 2016. június 6. 17:52
Címzett: Kiss Attila <[email protected]>; Kevin Smith
<[email protected]>
Másolatot kap: [email protected]
Tárgy: Re: [Geoserver-devel] geoserver WMS performance issue
Hi Attila,
fancy that, I looked at this a few days ago and I _believe_ this is caused by a
change
made some time ago in a commit message titled "Resource Pool performance patch
from Ordnance Survey". I see
a pull request for it here, even if the change got committed directly
afterwards:
https://github.com/geoserver/geoserver/pull/396/files
What I did not see back then is that now the check for cacheabiliy includes the
handleProjectionPolicy flag,
if false there is no caching... which is a problem since we always call with
that flag at false while grabbing
the feature source, and for sql views in particular, we have extra machinery
that makes sure the view cannot
be cached (there are reasons for that, cannot be removed, or two separate
requests would end up stepping on
each other toes).
So... if anything I would remove the "&& handleProjectionPolicy" here:
https://github.com/geoserver/geoserver/blame/master/src/main/src/main/java/org/geoserver/catalog/ResourcePool.java#L883
Kevin, do you know if there was a good reason to add it in the first place?
Attila, if you have the code handy could you verify if my suggestion helps (as
in, improves performance, and
causes no other obvious problems?)
Cheers
Andrea
On Mon, Jun 6, 2016 at 5:00 PM, Kiss Attila
<[email protected]<mailto:[email protected]>> wrote:
Hi Everybody,
I am using geoserver 2.8.3 with Oracle NG (JNDI) datasource. i have an SQL View
based wms layer.
I noticed that at org.geoserver.catalog.ResourcePool.java (line 929 ) there is
an internal check witch queries tha database at every WMS request.
the select is the following :
SELECT NULL AS table_cat,
o.owner AS table_schem,
o.object_name AS table_name,
o.object_type AS table_type,
NULL AS remarks
FROM all_objects o
WHERE o.owner LIKE :1 ESCAPE '/'
AND o.object_name LIKE :2 ESCAPE '/'
AND o.object_type IN ('xxx', 'TABLE', 'VIEW', 'SYNONYM')
ORDER BY table_type, table_schem, table_name;
Can somebody tell me why this query is running at every WMS request. Is a name
collision detection with database objects needed at every WMS request ?
because i thing this is a performance issue and a bug.
Or maybe i missing something …
Thanks for Help,
Kiss Attila
Ez a levél vírus- és spammentes. | This e-mail is virus-free.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Geoserver-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i
file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo
è consentito esclusivamente al destinatario del messaggio, per le finalità
indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne
il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di
procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte,
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse,
costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the
attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act (Legislative
Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in
accord with its purpose, any disclosure, reproduction, copying, distribution,
or either dissemination, either whole or partial, is strictly forbidden except
previous formal approval of the named addressee(s). If you are not the intended
recipient, please contact immediately the sender by telephone, fax or e-mail
and delete the information in this message that has been received in error. The
sender does not give any warranty or accept liability as the content, accuracy
or completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of e-mail
transmission, viruses, etc.
-------------------------------------------------------
Ez a levél vírus- és spammentes. | This e-mail is virus-free.
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
