On 29/07/16 09:52, Ben Caradoc-Davies wrote:
> On 28/07/16 19:39, Andrea Aime wrote:
>> My fault, I thought I merged that one and instead merged the backport on
>> 2.9.x (having both master pull and backport at the same time confused me).
>> I reverted the backport and merged the right one
>
> Thanks, Andrea. That fixed the compilation of backup-restore for me so I
> added it back to the communityRelease profile.

There is nothing in our Travis CI configuration to test whether a build 
with -DskipTests -PcommunityRelease succeeds. This means that we will 
not find out if a pull request targeting a community module breaks 
Jenkins on ares until it is merged.

Travis CI allows multiple script commands. At the cost of slower builds, 
would it be worthwhile to add coverage of communityRelease. The manual 
also documents the use of a "&&" short circuit to fail fast:
https://docs.travis-ci.com/user/customizing-the-build/

I think fail-fast is more appropriate as there is no point building with 
-PcommunityRelease as with two mvn commands there is not reactor to 
coordinate module dependencies.

I will make a pull request for your consideration.

Kind regards,

-- 
Ben Caradoc-Davies <[email protected]>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to