On Thu, Apr 13, 2017 at 7:30 AM Andrea Aime <andrea.a...@geo-solutions.it>
wrote:
> On Thu, Apr 13, 2017 at 3:17 PM, Justin Deoliveira <jdeol...@gmail.com>
> wrote:
>
>> Hey Andrea,
>>
>> Thanks for the input. Adding multiple keys at the top level would
>> certainly be an option, I just figured that since there are already quite a
>> few kml format options keys that having it encapsulated into a single one
>> would be a little nicer, and more aesthetically pleasing.
>>
>> To be clear I wasn’t proposing any change to format options syntax or
>> parser, just to see if someone had done this sort of thing before. My
>> thinking was that as long I chose delimiters that aren’t currently used (ie
>> not one of “&”, “=“, “:”, or “;”) then it should be pretty uninvasive and
>> not introduce any compatibility issues.
>>
>
> I'm not so sure, the format options parser is used for more than just
> format options:
>
> wfs/src/main/java/applicationContext.xml: <bean
> id="wfsFormatOptionsKvpParser"
> class="org.geoserver.ows.kvp.FormatOptionsKvpParser"/>
> wms/src/main/java/applicationContext.xml: <bean
> id="wmsFormatOptionsKvpParser"
> class="org.geoserver.ows.kvp.FormatOptionsKvpParser"/>
> wms/src/main/java/applicationContext.xml: <bean
> id="wmsEnviromentKvpParser"
> class="org.geoserver.ows.kvp.FormatOptionsKvpParser">
> wms/src/main/java/applicationContext.xml: <bean
> id="wmsLegendOptionsKvpParser"
> class="org.geoserver.ows.kvp.FormatOptionsKvpParser">
>
I see, so this would mean adding my option at the top level (rather than
inside of format_options) and having it use the same format_options syntax.
That would work.
>
> While I agree you can guess by looking at the existing format options what
> chars are not used (at least in the official GeoServer code base), I would
> not try to make the
> same guess about env vars (anything goes in there, imho). If you really
> want to go there, I'd add a parameter to limit the nested options
> properties to just the
> real format options parsers (the wms and wfs ones).
>
I am not really following here… so if I am going to add a new format option
(for whatever output format not necessarily kml) are you saying it’s only
safe to use a very limited character set for it’s value space? Like only
alphanumerics and no symbols?
>
> Cheers
> Andrea
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39 339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
> -------------------------------------------------------
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
