Andrea, this proposal is (almost) entirely confined to one module (gs-netcdf-out), changes no API, is (almost) fully backwards compatible in behaviour, and is fully backwards compatible in serialised settings. The GSIP might not even be required, but I thought it a useful way to ask for comments. I do not expect it to be contentious; I welcome all feedback.
There was some prior discussion on GeoTools PR #1417 <https://github.com/geotools/geotools/pull/1417> which was most helpful in dissuading me from that approach, and I also got an off-list analysis of the cost of opening NetCDF/GRIB files (I have asked for permission to copy it as a Jira comment). I agree that there was no response to my original proposal, perhaps because of the REST migration sprint, and perhaps because a module maintainer was on leave. The only feedback I got on this one was your comment on GEOT-5709 (thanks!). I hope that the screenshot, user manual section, and fully implemented pull requests will attract more attention. Kind regards, Ben. On 25/04/17 18:44, Andrea Aime wrote: > Hi Ben, > I've lost track of this one, seems like a step was skipped? > No big deal, but checking the history I see GSIP-158 switching from > a "preliminary discussion" thread (unfortunately empty) to a pull > request without a vote in the middle. > > Have I missed it? > > No big deal, we can vote and review at the same time. > > Cheers > Andrea > > > On Tue, Apr 25, 2017 at 5:09 AM, Ben Caradoc-Davies <[email protected]> > wrote: > >> I have submitted pull requests for review. >> >> See the GSIP 158 page for screenshot and user manual: >> https://github.com/geoserver/geoserver/wiki/GSIP-158 >> >> A small change is required to GeoTools: >> >> [GEOT-5709] Support coverage property SourceUrl >> https://github.com/geotools/geotools/pull/1564 >> https://osgeo-org.atlassian.net/browse/GEOT-5709 >> >> Most of the implementation is in GeoServer: >> >> [GEOS-8099] GSIP 158 - NetCDF output support for variable attributes and >> extra variables >> https://github.com/geoserver/geoserver/pull/2281 >> https://osgeo-org.atlassian.net/browse/GEOS-8099 >> >> Kind regards, >> Ben. >> >> On 25/03/17 17:15, Ben Caradoc-Davies wrote: >>> I have added some GitHub branch comparisons in the implementation >>> section. The implementation is incomplete; discussion comes first. It is >>> still too early for pull requests. >>> >>> On 25/03/17 16:59, Ben Caradoc-Davies wrote: >>>> Preliminary GSIP for discussion, no Jira issues yet: >>>> https://github.com/geoserver/geoserver/wiki/GSIP-158 >> >> -- >> Ben Caradoc-Davies <[email protected]> >> Director >> Transient Software Limited <http://transient.nz/> >> New Zealand >> >> ------------------------------------------------------------ >> ------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Geoserver-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
