+1 for option (2), reverting the GEOS-8117 fix. I would also revert the GEOS-8117 fix on master because the failure it causes masks any new CITE WFS 1.1 failures.
No good deed goes unpunished. Kind regards, Ben. On 13/05/17 19:55, Andrea Aime wrote: > I'd play it safe and revert, knowing there is a failure will make us ignore > the results and other failures may slip in. > > Also, the build server is public, having a failure (even a legit one) and > releasing anyways is bad rep imho > > Cheers > Andrea > > > Cheers > Andrea > > Il 13 mag 2017 1:08 AM, "Torben Barsballe" <tbarsba...@boundlessgeo.com> ha > scritto: > > Given that the 2.11.1 release is coming up soon, and I doubt I will be able > to fix this cite failure before then, what is the lesser of two evils here: > > 1. Let the CITE tests fail, given that the result is technically correct > (2.0.0 is the most recent version, the CITE tests are just old) > 2. Revert the GEOS-8117 <https://osgeo-org.atlassian.net/browse/GEOS-8117> fix > on 2.11.x and 2.10.x until I can get the CITE tests passing > > Torben > > On Wed, May 10, 2017 at 1:14 PM, Torben Barsballe < > tbarsba...@boundlessgeo.com> wrote: > >> Update: >> >> I'm working on a fix here: https://github.com/geose >> rver/geoserver/pull/2328 >> It seems to fix the issue in question, but still fails CITE tests. I am >> looking into a better solution. >> >> I've also set up a temporary Jenkins job for running WFS cite tests >> against an arbitrary branch here: http://ares.boundlessgeo >> .com/jenkins/job/cite-wfs-1.1-troubleshooting >> >> As an aside, this job seems like it is something that could be useful on a >> more permanent basis. >> >> Torben >> >> On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.a...@geo-solutions.it >>> wrote: >> >>> On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe < >>> tbarsba...@boundlessgeo.com> wrote: >>> >>>> Thanks Ben, I'll look into it. I remember taking a look at the failures >>>> around when I made that change and couldn't see anything problematic (it >>>> looked like just a curl failure near the end), but evidently that was just >>>> because I am not familiar in how the cite tests show errors. >>>> >>> >>> Because they don't... if you run them from command line you have to run a >>> separate tool >>> to get the report (I don't remember exactly how it works, never liked >>> using it that way). >>> When running them as a web application instead, you can follow a link to >>> go to that >>> specific error page, get a report, and run that one test again >>> >>> Cheers >>> Andrea >>> >>> -- >>> == >>> GeoServer Professional Services from the experts! Visit >>> http://goo.gl/it488V for more information. >>> == >>> >>> Ing. Andrea Aime >>> @geowolf >>> Technical Lead >>> >>> GeoSolutions S.A.S. >>> Via di Montramito 3/A >>> 55054 Massarosa (LU) >>> phone: +39 0584 962313 <+39%200584%20962313> >>> fax: +39 0584 1660272 <+39%200584%20166%200272> >>> mob: +39 339 8844549 <+39%20339%20884%204549> >>> >>> http://www.geo-solutions.it >>> http://twitter.com/geosolutions_it >>> >>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >>> >>> Le informazioni contenute in questo messaggio di posta elettronica e/o >>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >>> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >>> darcene notizia via e-mail e di procedere alla distruzione del messaggio >>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >>> principi dettati dal D.Lgs. 196/2003. >>> >>> >>> >>> The information in this message and/or attachments, is intended solely >>> for the attention and use of the named addressee(s) and may be confidential >>> or proprietary in nature or covered by the provisions of privacy act >>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >>> Code).Any use not in accord with its purpose, any disclosure, reproduction, >>> copying, distribution, or either dissemination, either whole or partial, is >>> strictly forbidden except previous formal approval of the named >>> addressee(s). If you are not the intended recipient, please contact >>> immediately the sender by telephone, fax or e-mail and delete the >>> information in this message that has been received in error. The sender >>> does not give any warranty or accept liability as the content, accuracy or >>> completeness of sent messages and accepts no responsibility for changes >>> made after they were sent or for other risks which arise as a result of >>> e-mail transmission, viruses, etc. >>> >>> ------------------------------------------------------- >>> >> >> > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
