Yeah, that might be trouble... thankfully strict matching is off by
default, after this change:
https://osgeo-org.atlassian.net/browse/GEOS-6811
Cheers
Andrea
On Wed, Jan 3, 2018 at 6:27 PM, Ian Turton <[email protected]> wrote:
> Actually looking closer it seems that the ':' will also be an issue, see
> line 144, if you have strict turned on,
>
> Ian
>
> On 3 January 2018 at 17:22, Ian Turton <[email protected]> wrote:
>
>> From a quick skim of the Paths class that seems reasonable, no idea what
>> it may break - I get 411 references to it in my workspace!
>>
>> Ian
>>
>> On 3 January 2018 at 17:04, Andrea Aime <[email protected]>
>> wrote:
>>
>>> Hi,
>>> runa test on Windows and it failed with this:
>>>
>>> java.lang.IllegalArgumentException: Contains invalid
>>> C:\devel\geoserver\src\web\core\target path:
>>> at org.geoserver.platform.resource.Paths.toPath(Paths.java:171)
>>> at org.geoserver.platform.resource.Paths.path(Paths.java:114)
>>> at org.geoserver.platform.resource.Paths.valid(Paths.java:194)
>>> at org.geoserver.platform.resource.FileSystemResourceStore.get(
>>> FileSystemResourceStore.java:112)
>>> at org.geoserver.platform.GeoServerResourceLoader.get(GeoServer
>>> ResourceLoader.java:164)
>>> at org.geoserver.web.wicket.browser.FileRootsFinder.getMatches(
>>> FileRootsFinder.java:99)
>>> at org.geoserver.web.wicket.browser.GeoServerFileChooserTest.te
>>> stAutocompleteDirectories(GeoServerFileChooserTest.java:164)
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
>>> ssorImpl.java:62)
>>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
>>> thodAccessorImpl.java:43)
>>> at java.lang.reflect.Method.invoke(Method.java:498)
>>> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
>>> FrameworkMethod.java:47)
>>> at org.junit.internal.runners.model.ReflectiveCallable.run(Refl
>>> ectiveCallable.java:12)
>>> at org.junit.runners.model.FrameworkMethod.invokeExplosively(Fr
>>> ameworkMethod.java:44)
>>> at org.junit.internal.runners.statements.InvokeMethod.evaluate(
>>> InvokeMethod.java:17)
>>> at org.junit.internal.runners.statements.RunBefores.evaluate(Ru
>>> nBefores.java:26)
>>> at org.junit.internal.runners.statements.RunAfters.evaluate(Run
>>> Afters.java:27)
>>> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
>>> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit
>>> 4ClassRunner.java:70)
>>> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit
>>> 4ClassRunner.java:50)
>>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>>> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
>>> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
>>> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
>>> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
>>> at org.junit.internal.runners.statements.RunBefores.evaluate(Ru
>>> nBefores.java:26)
>>> at org.junit.internal.runners.statements.RunAfters.evaluate(Run
>>> Afters.java:27)
>>> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
>>> at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.r
>>> un(JUnit4TestReference.java:86)
>>> at org.eclipse.jdt.internal.junit.runner.TestExecution.run(Test
>>> Execution.java:38)
>>> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTe
>>> sts(RemoteTestRunner.java:459)
>>> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTe
>>> sts(RemoteTestRunner.java:675)
>>> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(R
>>> emoteTestRunner.java:382)
>>> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(
>>> RemoteTestRunner.java:192)
>>>
>>> Seems like the path validation in the "resource" subsystem is not
>>> windows compatible? I believe this has come out before on the lists.
>>> Looks at the code in Paths, it seems to assume only "/" is the valid
>>> separator... this is trouble imho...
>>> It also goes fully nuts eventually because the file system resource
>>> code generates paths using "File", which uses "\" on Windows,
>>> so it generates paths that it considers itself invalid... this is
>>> insane! :-)
>>>
>>> I am tempted to replace all the usage of "/" in Paths with
>>> File.separator but... do you think it might cause other issues, at least in
>>> core
>>> modules? (I'm not too worried about the resoure store unsupported
>>> community module, but if you care, please show up and help?)
>>>
>>> Cheers
>>> Andrea
>>>
>>>
>>> On Wed, Jan 3, 2018 at 3:26 PM, Andrea Aime <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>> one of my pet peeves about the file chooser is that going throw its UI
>>>> is normally slow, click click click,
>>>> and if a directory has a lots of sub-directories, it takes time to list
>>>> contents and then lots of scrolling or
>>>> browser search tool to find the right entry.
>>>> I would love to just auto-complete in the path text editor instead...
>>>> and so here is a new pull
>>>> request:
>>>>
>>>> https://github.com/geoserver/geoserver/pull/2702
>>>>
>>>> The code auto-completes from the data dir or absolute paths (takes into
>>>> account all available roots),
>>>> makes partial and case insensitive matches so that one can just quickly
>>>> search for the bit she remembers,
>>>> and considers eventual file extensions configured in the editor.
>>>>
>>>> Examples from home directory:
>>>>
>>>> [image: Inline image 1]
>>>>
>>>> and relative path in the data directory instead:
>>>>
>>>> [image: Inline image 2]
>>>>
>>>> The code has been harder to write than expected, and so far it's tested
>>>> only on Linux,
>>>> not sure how it's going to behave on other platforms, coders helping
>>>> onother OSs would
>>>> be more than welcomed! (I want to give it a try on Windows, but the
>>>> sucker it's just installing
>>>> updates and telling me "the PC will be rebooted multiple times" since
>>>> an hour ago...).
>>>>
>>>> In any case, I've guarded auto-complete against exceptions, so if it
>>>> fails, it should simply
>>>> return an empty set of completions and log the error.
>>>>
>>>> Cheers
>>>> Andrea
>>>>
>>>> ==
>>>> GeoServer Professional Services from the experts! Visit
>>>> http://goo.gl/it488V for more information.
>>>> ==
>>>>
>>>> Ing. Andrea Aime
>>>> @geowolf
>>>> Technical Lead
>>>>
>>>> GeoSolutions S.A.S.
>>>> Via di Montramito 3/A
>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>>>> 55054 Massarosa
>>>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>>>> (LU)
>>>> phone: +39 0584 962313 <+39%200584%20962313>
>>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>>>
>>>> http://www.geo-solutions.it
>>>> http://twitter.com/geosolutions_it
>>>>
>>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>>>
>>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>>>> principi dettati dal D.Lgs. 196/2003.
>>>>
>>>> The information in this message and/or attachments, is intended solely
>>>> for the attention and use of the named addressee(s) and may be confidential
>>>> or proprietary in nature or covered by the provisions of privacy act
>>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>>>> copying, distribution, or either dissemination, either whole or partial, is
>>>> strictly forbidden except previous formal approval of the named
>>>> addressee(s). If you are not the intended recipient, please contact
>>>> immediately the sender by telephone, fax or e-mail and delete the
>>>> information in this message that has been received in error. The sender
>>>> does not give any warranty or accept liability as the content, accuracy or
>>>> completeness of sent messages and accepts no responsibility for changes
>>>> made after they were sent or for other risks which arise as a result of
>>>> e-mail transmission, viruses, etc.
>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> Regards,
>>>
>>> Andrea Aime
>>>
>>> ==
>>> GeoServer Professional Services from the experts! Visit
>>> http://goo.gl/it488V for more information.
>>> ==
>>>
>>> Ing. Andrea Aime
>>> @geowolf
>>> Technical Lead
>>>
>>> GeoSolutions S.A.S.
>>> Via di Montramito 3/A
>>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>>> 55054 Massarosa
>>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>>> (LU)
>>> phone: +39 0584 962313 <+39%200584%20962313>
>>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>>
>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>>> principi dettati dal D.Lgs. 196/2003.
>>>
>>> The information in this message and/or attachments, is intended solely
>>> for the attention and use of the named addressee(s) and may be confidential
>>> or proprietary in nature or covered by the provisions of privacy act
>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>>> copying, distribution, or either dissemination, either whole or partial, is
>>> strictly forbidden except previous formal approval of the named
>>> addressee(s). If you are not the intended recipient, please contact
>>> immediately the sender by telephone, fax or e-mail and delete the
>>> information in this message that has been received in error. The sender
>>> does not give any warranty or accept liability as the content, accuracy or
>>> completeness of sent messages and accepts no responsibility for changes
>>> made after they were sent or for other risks which arise as a result of
>>> e-mail transmission, viruses, etc.
>>>
>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>>
>>
>>
>> --
>> Ian Turton
>>
>
>
>
> --
> Ian Turton
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
