Hi,

Indeed GeoServer \ App-Schema is not respecting the standard, this looks like a bug to me.
+1 for considering this a bug and fix it on master, a PR to fix this is welcome 
:)

Back-porting is a bit more complex, since this may break existing expectations, let's see what others have to say about this. IMHO, if this is back-ported a flag to enable the old behavior should be provided.

Regards,

Nuno Oliveira

On 06/25/2018 06:18 PM, Daniel Urda wrote:
Hi,
While going over errors encountered by an app-schema based WFS service on Geoserver when testing with teamengine, I noticed that GeoTools currently encodes any simple attribute (having only a textnode) as a full object. It is my understanding that the WFS 2.0 standard requires such attributes to be returned as simple text nodes. The WFS 2.0 standard says that "The response shall be a text node or a list of element nodes that is the value of the node pointed to by the valueReference parameter." (section 10.2.4.3). Furthermore, see example GetPropertyValue exchanges in Annex B (e.g. sections B.4.5 and B.4.7)

Consequently, the following GET (taken from GeoServer's app-schema tests):
?request=GetPropertyValue&version=2.0.0&typename=gsml:MappedFeature&valueReference=gml:name&count=1

should return
<wfs:ValueCollection ...>
<wfs:member>GUNTHORPE FORMATION</wfs:member>
</wfs:ValueCollection>

instead of:
<wfs:ValueCollection ...>
<wfs:member>
<gml:name>GUNTHORPE FORMATION</gml:name>
</wfs:member>
</wfs:ValueCollection>

I expect any change to be breaking, thus I am interested what is the community's opinion on this issue (i.e. correct encoding of the GetPropertyValue  response). Looking a bit over the code, a "clean" solution doesn't appear trivial (if the current implementation is the one expected, I'll probably go for some quick&dirty hack for my local implementation)

Thank you,
Daniel Urda



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati
personali (Reg. UE 2016/679 - Regolamento generale sulla
protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto,
gli eventuali allegati, etc.) è un dato la cui conoscenza
è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è
tenuta/o a cancellarlo, ogni altra operazione è illecita.
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to
which it is addressed and may contain information that
is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European
Regulation 2016/679 “GDPR” - copying, dissemination or
use of this e-mail or the information herein by anyone
other than the intended recipient is prohibited. If you
have received this email by mistake, please notify
us immediately by telephone or e-mail.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to