Btw my +1 no this. We are successfully using this module since a long time on the GeoNode project too.
Il giorno mer 10 lug 2019 alle ore 01:22 Nuno Oliveira GeoSolutions < nuno.olive...@geo-solutions.it> ha scritto: > Hi Jody, > my apologies for the feedback delay, please find my answers bellow: > > On Tue, Jun 18, 2019 at 8:38 PM Jody Garnett <jody.garn...@gmail.com> > wrote: > >> That looks useful, tab for "module" status was intended to capture some >> of this information as well but was never followed up on. >> >> 0. status monitoring extension >> - I find the "service monitoring" name a bit confusing given the >> monitoring >> <https://docs.geoserver.org/latest/en/user/extensions/monitoring/index.html> >> extension, >> would it be more appropriate to call it "environment" or "system >> environment" extension? >> > > The name of the module is 'status-monitoring', but I'm all open to new > ideas, but I think the term monitoring should be part of the name, since > it allow us to monitor the system status, well if its become core this > should not be a problem anymore. > > >> - could consider taking this functionality into core rather than as an >> extension? >> > > Works for me, this module doesn't do anything unless the 'Monitoring' tab > is accessed, in the future if the functionality is extend to include a > small historic \ graphs then we will to give the option to the admin to > deactivate the metrics collectors. > > Is true that this module is frequently (always?) installed in most > GeoServer I have installed recently, I will reword the proposal to make it > core, unless someone objects. > > >> - does the REST API just provide a snapshot? Or access prior history >> (would it be appropriate to integrate this into the existing monitoring >> extension)+ >> > > Currently only snapshot, but history \ graphs is nice future that we may > have in the future :) > > Regarding the monitoring extension, IMHO that extension should have been > named 'Auditing', since it registers only the calls (unless I miss > something) that hit the system and doesn't record internal execution > details. But yes, adding system information to the requests auditing > information could be interesting. > > >> 1. usage/stability >> Yeah it is hard to show production use, let's take its creation in 2017 >> and continued development as evidence of stability :) >> > > :) > > >> 2. active/maintainer >> thanks >> 3. stable >> I have no direct experience, module has not broken the build... >> 4. coverage >> 5. no ip violations >> - we need to reword this to be a check of dependencies/headers/code >> donation. >> - pom.xml >> <https://github.com/geoserver/geoserver/blob/master/src/community/status-monitoring/pom.xml> >> does >> not list you as maintainer / contact point (aside: will need to set up jira >> component for this as a new extension) >> > > I will fix that in my next update. > > >> - license of OSHI changed from EPL (copyleft) to MIT (permissive) >> recently <https://github.com/oshi/oshi/issues/593> - what version are we >> using? >> > > The PR has been updated to upgrade to the very last version, which is > released under MTI License. > > >> - very limited internationalization >> <https://github.com/geoserver/geoserver/blob/master/src/community/status-monitoring/src/main/resources/GeoServerApplication.properties>, >> think this needs to be fixed up? We do not have a checklist for coding >> standards ... >> > > Implementation of internationalization support in progress, PR already > updated with a first attempt. > > >> - no surprises going through the rest of it ... >> 6. page in user manual >> - Status Monitoring >> <https://docs.geoserver.org/latest/en/user/community/status-monitoring/index.html> >> - For REST API we have the additional requirement to provide swagger docs >> for our published api. See example for monitoring requests >> <https://docs.geoserver.org/latest/en/api/#/latest/en/api/1.0.0/monitoring.yaml> >> . >> > > Good point, it will be fixed. > > >> 7. contributor agreement >> - We could ask that a Software Grant and Corporate Contributor License >> Agreement >> <https://www.osgeo.org/resources/corporate-contributor-license/> be sent >> in since this is a donation of code. There is a section at the end to name >> the item donate to OSGeo. >> > > I will check this with my employer, I don't think it will be against it :P > > >> -- >> Jody Garnett >> >> >> On Tue, 18 Jun 2019 at 11:16, Nuno Oliveira < >> nuno.olive...@geo-solutions.it> wrote: >> >>> Dear all, Project Steering Committee, >>> >>> I would like to promote the Status Monitoring community to an official >>> extension, I wrote a GSIP here: >>> https://github.com/geoserver/geoserver/wiki/GSIP-175 >>> >>> Please let me know if I missed something. >>> >>> Kind regards, >>> Nuno Oliveira >>> >>> -- >>> Regards, >>> Nuno Oliveira >>> == >>> GeoServer Professional Services from the >>> experts! >>> Visit http://goo.gl/it488V for more information. >>> == >>> >>> Nuno Miguel Carvalho Oliveira >>> @nmcoliveira >>> Software Engineer >>> >>> GeoSolutions S.A.S. >>> Via di Montramito 3/A >>> 55054 Massarosa (LU) >>> Italy >>> phone: +39 0584 962313 >>> fax: +39 0584 1660272 >>> http://www.geo-solutions.ithttp://twitter.com/geosolutions_it >>> >>> ------------------------------------------------------- >>> >>> Con riferimento alla normativa sul trattamento dei dati >>> personali (Reg. UE 2016/679 - Regolamento generale sulla >>> protezione dei dati “GDPR”), si precisa che ogni >>> circostanza inerente alla presente email (il suo contenuto, >>> gli eventuali allegati, etc.) è un dato la cui conoscenza >>> è riservata al/i solo/i destinatario/i indicati dallo >>> scrivente. Se il messaggio Le è giunto per errore, è >>> tenuta/o a cancellarlo, ogni altra operazione è illecita. >>> Le sarei comunque grato se potesse darmene notizia. >>> >>> This email is intended only for the person or entity to >>> which it is addressed and may contain information that >>> is privileged, confidential or otherwise protected from >>> disclosure. We remind that - as provided by European >>> Regulation 2016/679 “GDPR” - copying, dissemination or >>> use of this e-mail or the information herein by anyone >>> other than the intended recipient is prohibited. If you >>> have received this email by mistake, please notify >>> us immediately by telephone or e-mail. >>> >>> _______________________________________________ >>> Geoserver-devel mailing list >>> Geoserver-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >> > > -- > Regards, > Nuno Oliveira > == > GeoServer Professional Services from the experts! > Visit http://goo.gl/it488V for more information. > == > > Nuno Miguel Carvalho Oliveira > @nmcoliveira > Software Engineer > > GeoSolutions S.A.S. > Via di Montramito 3/A > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati > personali (Reg. UE 2016/679 - Regolamento generale sulla > protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, > gli eventuali allegati, etc.) è un dato la cui conoscenza > è riservata al/i solo/i destinatario/i indicati dallo > scrivente. Se il messaggio Le è giunto per errore, è > tenuta/o a cancellarlo, ogni altra operazione è illecita. > Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to > which it is addressed and may contain information that > is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European > Regulation 2016/679 “GDPR” - copying, dissemination or > use of this e-mail or the information herein by anyone > other than the intended recipient is prohibited. If you > have received this email by mistake, please notify > us immediately by telephone or e-mail. > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Alessio Fabiani @alfa7691 Founder/Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A - 55054 Massarosa (LU) - Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 331 6233686 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
