+1 -Jukka Rahkonen-
Lähettäjä: Nuno Oliveira <nuno.olive...@geo-solutions.it> Lähetetty: maanantai 5. elokuuta 2019 12.35 Vastaanottaja: Jody Garnett <jody.garn...@gmail.com>; fernando.m...@geo-solutions.it Kopio: GeoServer <geoserver-devel@lists.sourceforge.net> Aihe: Re: [Geoserver-devel] GSIP 175 - Promote status monitoring module from Community to Extension Dear PSC, I would kindly ask you if you can vote on this one, proposal link for reference: https://github.com/geoserver/geoserver/wiki/GSIP-175 Thank you! On Wed, 2019-07-31 at 09:03 +0100, Nuno Oliveira wrote: Dear all, Jody, thank you for the feedback! We have implemented the feedback we got in this two PRs: * https://github.com/geoserver/geoserver/pull/3590 (2.16.x core) * https://github.com/geoserver/geoserver/pull/3688 (2.15.x extension) Summarizing the feedback that was applied: * migrated to the latest version of OSHI, MIT License * renamed the module to system-status * added internationalization support * added swagger documentation for the REST API * make it core in 2.16.x * documentation moved to configuration status [1] * make it an extension to 2.15.x Please let's us know if we missed anything. Kind regards, Nuno Oliveira [1] https://docs.geoserver.org/stable/en/user/configuration/status.html On Thu, 2019-07-25 at 17:27 -0700, Jody Garnett wrote: Those activities sound fine, may also need to move some documentation around also? I have made sure to add my +1 to the proposal. -- Jody Garnett On Thu, 25 Jul 2019 at 11:04, fernando.m...@geo-solutions.it<mailto:fernando.m...@geo-solutions.it> <fernando.m...@geo-solutions.it<mailto:fernando.m...@geo-solutions.it>> wrote: Hi all, I have a proposal for integrate promoted system-status module code into Geoserver core on master: Relocate System status logic classes: Rename package org.geoserver.status.monitoring.collector to org.geoserger.systemstatus Put it in gs-main module. Relocate Web classes: Rename package org.geoserver.status.monitoring.web to org.geoserver.web.systemstatus Put it in gs-web-core module. Relocate Rest classes: rename package org.geoserver.status.monitoring.rest to org.geoserver.rest.systemstatus Put it in gs-restconfig module. What do you think about? Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Fernando Mino Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. From "Nuno Oliveira" nuno.olive...@geo-solutions.it<mailto:nuno.olive...@geo-solutions.it> To andrea.a...@geo-solutions.it<mailto:andrea.a...@geo-solutions.it> Cc "geoserver-devel" geoserver-devel@lists.sourceforge.net<mailto:geoserver-devel@lists.sourceforge.net> Date Wed, 10 Jul 2019 09:53:02 +0100 Subject Re: [Geoserver-devel] GSIP 175 - Promote status monitoring module from Community to Extension Thank you all for the feedback, answering the open points: * regarding the naming: * what do you think about renaming it to system-status? * regarding the promotion to core, I would suggest the following steps: * promote to extension in 2.15.x * promote to core in master (2.16.x) Do we have a enough information to start a vote? if yes I will kindly ask you to vote on this GISP :) On Wed, 2019-07-10 at 10:00 +0200, Andrea Aime wrote: On Wed, Jul 10, 2019 at 1:23 AM Nuno Oliveira GeoSolutions <nuno.olive...@geo-solutions.it<mailto:nuno.olive...@geo-solutions.it>> wrote: - could consider taking this functionality into core rather than as an extension? Works for me, this module doesn't do anything unless the 'Monitoring' tab is accessed, in the future if the functionality is extend to include a small historic \ graphs then we will to give the option to the admin to deactivate the metrics collectors. Hum... core directly? I did not see that coming. But If that's the case, a simple way to solve the naming problem, is not to name it, and spread its classes in gs-main, gs-restconfig and gs-web-core instead Just thinking out loud :-D Of course, there is a downside of going this direction... it makes proposing a backport harder, I think it's the first time a module goes straight from community to core (actually, the first time anything in extension or community goes in core, in a very long long time). That said, the module is really a handful of classes and I know first hand it has been added to a lot of installations so far so... no objection. Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net<mailto:Geoserver-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net<mailto:Geoserver-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
