On Sat, Dec 11, 2021 at 1:18 PM mark <mc.pr...@gmail.com> wrote:

> Seeing the many (failing) PR's from transifex because of encoding
> problems; it seems wasteful to run the whole CI chain for each and every
> update of a property file.
>

It is indeed. Similarly, it does not make sense to run the whole build for
just a documentation change, as only the doc build would be used there.

I believe the same can be said for anything inside "/data"
and "/build".
However, careful about ignoring property files, see below.


> I would like to suggest only running the QA workflow and none of the
> others by filtering the changes using the paths-ignore option as
> described here:
>
> https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-ignoring-paths
>
> I think something like the following to be added to the workflows to be
> skipped:
>
> on:
>    pull_request:
>      paths-ignore:
>        - '**.properties'
>
> Or perhaps a bit more specific:
>
> '**/src/main/resources/GeoServerApplication_*.properties'
>

Right, this one would be much better. The GUI tests are actually mostly
using the english property files (GeoServerApplication.properties)
so we can ignore running builds for translation files in other languages.

StyleEditPageRenameTest is an exception, it's actually checking its own
french translation.
The language chooser GUI will also need some test, I can write them using
French... so that you
can just skip the build for all other languages?

Cheers
Andrea

PS: the raft of PRs was automatically sent by Transifex, they were not
meant to be worked on, I've closed
them as per Alexandre request.

==

GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions Group
phone: +39 0584 962313

fax:     +39 0584 1660272

mob:   +39  333 8128928

https://www.geosolutionsgroup.com/

http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
precisa che ogni circostanza inerente alla presente email (il suo
contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is
addressed and may contain information that is privileged, confidential or
otherwise protected from disclosure. We remind that - as provided by
European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
e-mail or the information herein by anyone other than the intended
recipient is prohibited. If you have received this email by mistake, please
notify us immediately by telephone or e-mail
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to