Jody here with some notes for the discussion: 1. The documentation refers to these as built-in logging configurations. I think it is good that the built-in logging configurations are available for use as an example (rather than just hidden in a jar).
https://docs.geoserver.org/main/en/user/configuration/logging.html 2. The documentation on customization (above) has an example that starts with copying a built-in configuration and making changes. 3. The blog post has some more details on updating from properties --> xml; but also updating about the built-in xml definitions updating each release. Reading the blog post it just has an example using properties and not an xml file. If you made any customizations to the built-in profiles, you can recover your changes from backup bak file. You can use this backup as a reference when creating a new xml logging profile, or restore this under a different name which does not conflict with the built-in logging profiles. 4. I do expect these logging configuration to change over time, see bug https://osgeo-org.atlassian.net/browse/GEOS-10701 for an example. As such it is nice to treat these as built-in and managed as part of the software. aside: Initially I tried writing some code that checked if the built-in files had been customized; and only update ones that had not had their checksum change. PR review guidance was to simplify the code. Perhaps reviewers were thinking it was only applying with updating from properties --> xml and not an ongoing policy. -- Jody On Sat, Oct 8, 2022 at 7:33 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > Sel correction: GeoServer will bulldoze the file the moment one changes > the logging profile, so the edit will really never take. > Hopefully one is working with an editor still open, and smart enough to > tell them "hey, the file just got modified". > > Cheers > Andrea > > > On Sat, Oct 8, 2022 at 11:27 AM Andrea Aime < > andrea.a...@geosolutionsgroup.com> wrote: > >> You have a good point about predictability. At the same time, it's >> shocking to be able to edit a file, have it working fine for >> a while, and then find out it reverted back to a previous state >> days/weeks/months later, when a restart happens. >> >> The other surprising bit is the change of behavior, after so many years >> being able to just edit these files without surprises. >> >> Cheers >> Andrea >> >> On Fri, Oct 7, 2022 at 9:20 PM Alexandre Gacon <alexandre.ga...@gmail.com> >> wrote: >> >>> I think I understand the point of Jody. If the definition of the level >>> of logging stays the same, you know you can have a given information by >>> asking a customer or a user to set the logging to level YYY. >>> >>> If the definition has been changed, you won't have the information to >>> help him or her. >>> >>> To me it should be possible to define several custom logging levels. For >>> the default one, the only thing that should be allowed to be changed should >>> be the location of the file or a rolling policy but not the content of the >>> log. >>> >>> Alexandre >>> >>> Le ven. 7 oct. 2022 à 19:58, Ian Turton <ijtur...@gmail.com> a écrit : >>> >>>> Overwriting an existing file seems wrong to me. I for one would be >>>> surprised if it happened to me. >>>> >>>> Ian >>>> >>>> On Fri, 7 Oct 2022, 18:20 Andrea Aime, < >>>> andrea.a...@geosolutionsgroup.com> wrote: >>>> >>>>> Hi all, >>>>> I'm bringing a discussion started in >>>>> https://osgeo-org.atlassian.net/browse/GEOS-10700 here on list, >>>>> because I believe it needs a wider audience. >>>>> >>>>> In summary, it's no longer possible to customize the logging profiles >>>>> that ship with GeoServer (e..g, PRODUCTION_LOGGING.xml, as found in a >>>>> vanilla GeoServer installation) because GeoServer would overwrite them on >>>>> startup with the classpath version. >>>>> >>>>> The "intended" way would be to create a customized profile, >>>>> "MY_PRODUCTION_LOGGING", that would sit alongside the one provided by >>>>> GeoServer. >>>>> >>>>> Jody says it's a feature... I see it as surprising, and verbose >>>>> configuration wise (why should one keep logging profiles they don't care >>>>> to >>>>> use as-is, and put another alongside with the same intended purpose?). >>>>> >>>>> Can we please restore the old behavior? If the admin customizes a >>>>> built-in profile in XML form, it just stays that way. GeoServer should >>>>> fill >>>>> back in the logging profiles only if they have been deleted... >>>>> >>>>> Cheers >>>>> Andrea >>>>> >>>>> == >>>>> >>>>> GeoServer Professional Services from the experts! >>>>> >>>>> Visit http://bit.ly/gs-services-us for more information. >>>>> == >>>>> >>>>> Ing. Andrea Aime >>>>> @geowolf >>>>> Technical Lead >>>>> >>>>> GeoSolutions Group >>>>> phone: +39 0584 962313 >>>>> >>>>> fax: +39 0584 1660272 >>>>> >>>>> mob: +39 339 8844549 >>>>> >>>>> https://www.geosolutionsgroup.com/ >>>>> >>>>> http://twitter.com/geosolutions_it >>>>> >>>>> ------------------------------------------------------- >>>>> >>>>> Con riferimento alla normativa sul trattamento dei dati personali >>>>> (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati >>>>> “GDPR”), >>>>> si precisa che ogni circostanza inerente alla presente email (il suo >>>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>>>> >>>>> This email is intended only for the person or entity to which it is >>>>> addressed and may contain information that is privileged, confidential or >>>>> otherwise protected from disclosure. We remind that - as provided by >>>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of >>>>> this >>>>> e-mail or the information herein by anyone other than the intended >>>>> recipient is prohibited. If you have received this email by mistake, >>>>> please >>>>> notify us immediately by telephone or e-mail >>>>> _______________________________________________ >>>>> Geoserver-devel mailing list >>>>> Geoserver-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>>> >>>> _______________________________________________ >>>> Geoserver-devel mailing list >>>> Geoserver-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >> >> -- >> >> Regards, >> >> Andrea Aime >> >> == >> GeoServer Professional Services from the experts! >> >> Visit http://bit.ly/gs-services-us for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions Group >> phone: +39 0584 962313 >> >> fax: +39 0584 1660272 >> >> mob: +39 339 8844549 >> >> https://www.geosolutionsgroup.com/ >> >> http://twitter.com/geosolutions_it >> >> ------------------------------------------------------- >> >> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >> precisa che ogni circostanza inerente alla presente email (il suo >> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >> >> This email is intended only for the person or entity to which it is >> addressed and may contain information that is privileged, confidential or >> otherwise protected from disclosure. We remind that - as provided by >> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >> e-mail or the information herein by anyone other than the intended >> recipient is prohibited. If you have received this email by mistake, please >> notify us immediately by telephone or e-mail >> > > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- -- Jody Garnett
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
