On Tue, Mar 26, 2013 at 5:54 PM, Simon Hartley <[email protected]>wrote:
> Hello,****
>
> ** **
>
> Currently if I do separate GetFeatureInfo requests for each layer I can
> specify a different buffer parameter for each layer.****
>
> When trying to combine the separate requests I discover that I can only
> specify a single buffer.****
>
> Is it a valid enhancement to allow buffer to accept a different value for
> each layer?
>
It sounds like a valid enhancement to me.
> ****
>
> ** GetMap would probably need to be enhanced at the same time.
>
The buffer in GetMap determines the extra search area for features whose
geometry is outside of the requested area,
but whose symbolizer is big enough to make it appear in the painted map
anyways.
This is sent down to GeoTools as a single value, if you want to really make
that per layer instead of just picking
the highest value, you'll have to modify GeoTools StreamingRenderer and
Layer classes, which would be an API
change over there (thus, subject to a format proposal, and limited to
trunk, you can backport to the stable series
only with a positive vote of the project management committee).
> **
>
> Also it would be necessary for any layer to be able to opt-out of
> specifying a buffer and just let the automatic, SLD-based calculation be
> used.
>
No, this one does not make sense. There is already a limit on the maximum
buffer size (I believe it's 20?), why
add this extra complication?
If the caller does not want to specify a buffer for a certain layer, we can
leave it empty like in styles, e.g.
buffer=10,15,,17
> ****
>
> I’ve had a look at the source and although it seems a relatively simple
> change, there are aspects that I don’t understand (possibly there’s some
> reflection going on).****
>
> Do I need to add a ticket?
>
Yes, a ticket is required. Also a junit test for every new behavior you add.
Given this is a new feature, things would work like in GeoTools, first
commit on trunk after passing a review,
and then call the project steering committee for a vote in order to
backport on the stable series.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
Geoserver-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users
