That is odd, especially as OraclFilterToSQL calls setSqlNameEscape("\"") in
it's constructor. Since we currently have working Oracle CI tests I may
have a quick go at an update,
Note that encodeColumnName does include the following:
// need to quote column names with spaces in
if (raw.contains(" ")) {
raw = "\"" + raw + "\"";
}
Ian
On Tue, 4 Aug 2020 at 13:20, Andrea Aime <andrea.a...@geo-solutions.it>
wrote:
> Hi Ian,
> the thing is, that would be the default behavior, and it has been
> explicitly overridden so it does not happen.
> Goes way back, it's not covered by the git history, one would have to
> check in the old SVN history to
> see if there is a commit about it.
>
> Had a very quick look, 2.6.0 is the first tag where the OracleDialect
> class appears in its present location,
> and it was already like that, search for "getNameEscape":
>
> https://svn.osgeo.org/geotools/tags/2.6.0/modules/plugin/jdbc/jdbc-oracle/src/main/java/org/geotools/data/oracle/OracleDialect.java
>
> Going back to the pre-JDBCDataStore times, the stand-alone oracle-spatial
> module also did not escape names, e.g.:
>
> https://svn.osgeo.org/geotools/tags/2.5.0/modules/unsupported/oracle-spatial/src/main/java/org/geotools/data/oracle/SqlStatementEncoder.java
>
> Cheers
> Andrea
>
> On Tue, Aug 4, 2020 at 2:12 PM Ian Turton <ijtur...@gmail.com> wrote:
>
>> It should be relatively easy to modify encodeColumnName in OracleDialect
>> to surround reserved words with " - and possibly make use of the
>> sqlNameEscape value and escapeName function in FilterToSql too
>>
>> Ian
>>
>> On Tue, 4 Aug 2020 at 12:15, d'Orio, Pietro <pietro.do...@siag.it> wrote:
>>
>>> The following keywords don't make problem:
>>> - ID, GEOMETRY, TYPE
>>>
>>> The query on DB is like: SELECT GEOMETRY AS GEOMETRY FROM TABLE
>>>
>>> The following makes problem:
>>> - LEVEL, DATE
>>>
>>> i have to rename the view fields, but i think is a mistake that some
>>> sensible oracle keywords works and other not…
>>>
>>> If I have an obligation to display the data according to specifications,
>>> I can't! For example, Inspire provides for some fields called "LEVEL".
>>>
>>> Regards
>>>
>>> -----Messaggio originale-----
>>> Da: Richard Duivenvoorde <rdmaili...@duif.net>
>>> Inviato: lunedì 3 agosto 2020 20:20
>>> A: andrea.a...@geo-solutions.it; Rahkonen Jukka (MML) <
>>> jukka.rahko...@maanmittauslaitos.fi>
>>> Cc: geoserver-users@lists.sourceforge.net
>>> Oggetto: Re: [Geoserver-users] WFS GetFeature does not work with field
>>> "DATE"
>>>
>>> Also see the answer of Stefan in the issue Pietro created:
>>> https://osgeo-org.atlassian.net/browse/GEOS-9712
>>>
>>> Regards,
>>>
>>> Richard Duivenvoorde
>>>
>>> On 8/3/20 8:07 PM, Andrea Aime wrote:
>>> > Hi Jukka,
>>> > having a quick look at the code, indeed the name quoting is explicitly
>>> > disabled in Oracle, and it has been since many years (probably since
>>> the version of the Oracle support code).
>>> > If memory serves me correctly, Oracle Spatial has some weird naming
>>> > limitations on top of the already restrictive Oracle naming
>>> > conventions... something like, table and geometry columns must
>>> actually be all uppercase in the queries for anything to work (can't
>>> remember exactly).
>>> > Cheers
>>> > Andrea
>>> >
>>> >
>>> > On Mon, Aug 3, 2020 at 7:41 PM Rahkonen Jukka (MML) <
>>> jukka.rahko...@maanmittauslaitos.fi <mailto:
>>> jukka.rahko...@maanmittauslaitos.fi>> wrote:
>>> >
>>> > Hi,
>>> >
>>> > Does it mean that Oracle NG builds queries as nonquoted and the
>>> result is
>>> > SELECT DATE FROM TABLE instead of
>>> > SELECT "DATE" FROM "TABLE", that would work?
>>> >
>>> > From the referred Oracle document:
>>> >
>>> > "This section lists Oracle SQL reserved words. You cannot use
>>> Oracle SQL reserved words as nonquoted identifiers. Quoted identifiers can
>>> be reserved words, although this is not recommended."
>>> >
>>> > -Jukka Rahkonen-
>>> >
>>> > -----Alkuperäinen viesti-----
>>> > Lähettäjä: Mark Prins <mc.pr...@gmail.com <mailto:
>>> mc.pr...@gmail.com>>
>>> > Lähetetty: maanantai 3. elokuuta 2020 18.01
>>> > Vastaanottaja: geoserver-users@lists.sourceforge.net <mailto:
>>> geoserver-users@lists.sourceforge.net>
>>> > Aihe: Re: [Geoserver-users] WFS GetFeature does not work with
>>> field "DATE"
>>> >
>>> > On 03-08-2020 11:00, d'Orio, Pietro wrote:
>>> > > If an Oracle NG (JNDI) layer contain a field "DATE" the WFS does
>>> not
>>> > > work for this layer.
>>> > >
>>> > > Also other "sensitive" oracle DB tags like "SIZE" or "LOCATION"
>>> cause
>>> > > the same problem.
>>> > >
>>> > > A special note: "TYPE" does not cause problems
>>> >
>>> > TYPE is not in the list:
>>> >
>>> https://docs.oracle.com/database/121/SQLRF/ap_keywd001.htm#SQLRF55621
>>> > (but neither is LOCATION or SIZE so I'm not sure what is going on
>>> there) If you set up geoserver with geotools developer or debug logging you
>>> can see the generated queries in the log.
>>> >
>>> > As linked there
>>> >
>>> https://docs.oracle.com/database/121/REFRN/GUID-6D03E5B5-A23B-499C-B6BC-A31A12FC6C7D.htm#REFRN30204
>>> > talks about which words vcaanot be used where in Orcla, documented
>>> > in V$RESERVED_WORDS in your database (the list can/will vary between
>>> > versions)
>>> >
>>> > - M
>>> >
>>> >
>>> > _______________________________________________
>>> > Geoserver-users mailing list
>>> >
>>> > Please make sure you read the following two resources before
>>> posting to this list:
>>> > - Earning your support instead of buying it, but Ian Turton:
>>> http://www.ianturton.com/talks/foss4g.html#/
>>> > - The GeoServer user list posting guidelines:
>>> > http://geoserver.org/comm/userlist-guidelines.html
>>> >
>>> > If you want to request a feature or an improvement, also see this:
>>> > https://github.com/geoserver/geoserver/wiki/Successfully-requesting-an
>>> > d-integrating-new-features-and-improvements-in-GeoServer
>>> >
>>> >
>>> > Geoserver-users@lists.sourceforge.net <mailto:
>>> Geoserver-users@lists.sourceforge.net>
>>> > https://lists.sourceforge.net/lists/listinfo/geoserver-users
>>> >
>>> >
>>> > _______________________________________________
>>> > Geoserver-users mailing list
>>> >
>>> > Please make sure you read the following two resources before
>>> posting to this list:
>>> > - Earning your support instead of buying it, but Ian Turton:
>>> http://www.ianturton.com/talks/foss4g.html#/
>>> > - The GeoServer user list posting guidelines:
>>> > http://geoserver.org/comm/userlist-guidelines.html
>>> >
>>> > If you want to request a feature or an improvement, also see this:
>>> > https://github.com/geoserver/geoserver/wiki/Successfully-requesting-an
>>> > d-integrating-new-features-and-improvements-in-GeoServer
>>> >
>>> >
>>> > Geoserver-users@lists.sourceforge.net <mailto:
>>> Geoserver-users@lists.sourceforge.net>
>>> > https://lists.sourceforge.net/lists/listinfo/geoserver-users
>>> >
>>> >
>>> >
>>> > --
>>> >
>>> > Regards, Andrea Aime
>>> >
>>> > == GeoServer Professional Services from the experts! Visit
>>> > http://goo.gl/it488V for more information. == Ing. Andrea Aime
>>> > @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A
>>> > 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob:
>>> > +39 339 8844549 http://www.geo-solutions.it
>>> > http://twitter.com/geosolutions_it
>>> > ------------------------------------------------------- /Con
>>> > riferimento alla normativa sul trattamento dei dati personali (Reg. UE
>>> > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
>>> > precisa che ogni circostanza inerente alla presente email (il suo
>>> > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
>>> > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
>>> > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
>>> > operazione è illecita. Le sarei comunque grato se potesse darmene
>>> > notizia. This email is intended only for the person or entity to which
>>> > it is addressed and may contain information that is privileged,
>>> > confidential or otherwise protected from disclosure. We remind that -
>>> > as provided by European Regulation 2016/679 “GDPR” - copying,
>>> > dissemination or use of this e-mail or the information herein by
>>> > anyone other than the intended recipient is prohibited. If you have
>>> > received this email by mistake, please notify us immediately by
>>> > telephone or e-mail./
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > Geoserver-users mailing list
>>> >
>>> > Please make sure you read the following two resources before posting
>>> to this list:
>>> > - Earning your support instead of buying it, but Ian Turton:
>>> > http://www.ianturton.com/talks/foss4g.html#/
>>> > - The GeoServer user list posting guidelines:
>>> > http://geoserver.org/comm/userlist-guidelines.html
>>> >
>>> > If you want to request a feature or an improvement, also see this:
>>> > https://github.com/geoserver/geoserver/wiki/Successfully-requesting-an
>>> > d-integrating-new-features-and-improvements-in-GeoServer
>>> >
>>> >
>>> > Geoserver-users@lists.sourceforge.net
>>> > https://lists.sourceforge.net/lists/listinfo/geoserver-users
>>> >
>>>
>>>
>>> _______________________________________________
>>> Geoserver-users mailing list
>>>
>>> Please make sure you read the following two resources before posting to
>>> this list:
>>> - Earning your support instead of buying it, but Ian Turton:
>>> http://www.ianturton.com/talks/foss4g.html#/
>>> - The GeoServer user list posting guidelines:
>>> http://geoserver.org/comm/userlist-guidelines.html
>>>
>>> If you want to request a feature or an improvement, also see this:
>>> https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
>>>
>>>
>>> Geoserver-users@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-users
>>>
>>> _______________________________________________
>>> Geoserver-users mailing list
>>>
>>> Please make sure you read the following two resources before posting to
>>> this list:
>>> - Earning your support instead of buying it, but Ian Turton:
>>> http://www.ianturton.com/talks/foss4g.html#/
>>> - The GeoServer user list posting guidelines:
>>> http://geoserver.org/comm/userlist-guidelines.html
>>>
>>> If you want to request a feature or an improvement, also see this:
>>> https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
>>>
>>>
>>> Geoserver-users@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-users
>>>
>>
>>
>> --
>> Ian Turton
>>
>
>
> --
>
> Regards, Andrea Aime
>
> == GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> ------------------------------------------------------- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>
--
Ian Turton
_______________________________________________
Geoserver-users mailing list
Please make sure you read the following two resources before posting to this
list:
- Earning your support instead of buying it, but Ian Turton:
http://www.ianturton.com/talks/foss4g.html#/
- The GeoServer user list posting guidelines:
http://geoserver.org/comm/userlist-guidelines.html
If you want to request a feature or an improvement, also see this:
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users
