Why I ask this is that I am trying to build a custom datastore which only
require one parameter "url" to the path, and the path is a directory.
So the `ShapefileDirectoryDataStore` will be returned back early.
Fine, I will tried to add a new Param for the factory and to see if this can be
solved.
------------------ Original ------------------
From: "andrea.aime";<[email protected]>;
Send time: Friday, Oct 16, 2020 5:05 PM
To: "Yang"<[email protected]>;
Cc: "geoserver-users"<[email protected]>;
Subject: Re: [Geoserver-users] why ResourcePool retrieve DataStore by
parameters?
On Fri, Oct 16, 2020 at 10:52 AM Yang <[email protected]> wrote:
Also, I wonder why it does not use the type of the DataStoreInfo to get the
result directly?
Because we occasionally rewrite the datastores from the ground up, this has
happened for all JDBC stores,
and for the WFS store for example. If the code was looking for a specific
factory, the upgrade
from the old to the new generation of the store would not be transparent
anymore (the old and new
share the same params, they are never in the classpath at the same time).
A situation where two stores share the same mandatory parameters is considered
broken design,
core stores are set up not to share them (e.g., the JDBC store have a db_type
parameter to tell them apart).
I guess the code could be looking for a well known factory first and fall back
to parameters lookup
if it's not found, but we haven't had a need for that so far
Cheers
Andrea
== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions
S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax:
+39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it
http://twitter.com/geosolutions_it
------------------------------------------------------- Con riferimento alla
normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento
generale sulla protezione dei dati ??GDPR??), si precisa che ogni circostanza
inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.)
?? un dato la cui conoscenza ?? riservata al/i solo/i destinatario/i indicati
dallo scrivente. Se il messaggio Le ?? giunto per errore, ?? tenuta/o a
cancellarlo, ogni altra operazione ?? illecita. Le sarei comunque grato se
potesse darmene notizia. This email is intended only for the person or entity
to which it is addressed and may contain information that is privileged,
confidential or otherwise protected from disclosure. We remind that - as
provided by European Regulation 2016/679 ??GDPR?? - copying, dissemination or
use of this e-mail or the information herein by anyone other than the intended
recipient is prohibited. If you have received this email by mistake, please
notify us immediately by telephone or e-mail.
_______________________________________________
Geoserver-users mailing list
Please make sure you read the following two resources before posting to this
list:
- Earning your support instead of buying it, but Ian Turton:
http://www.ianturton.com/talks/foss4g.html#/
- The GeoServer user list posting guidelines:
http://geoserver.org/comm/userlist-guidelines.html
If you want to request a feature or an improvement, also see this:
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users
