Justin Deoliveira wrote:
Jody Garnett wrote:
Justin Deoliveira wrote:

Hi all,

To summarize up front, I would like to change the type of the "ContrastEnhancment" reference on SelectedChannelType from Expression to ContrastEhnancment. Continue on for more details.

and matches up nicely with the spec. So I would like to change the type of the reference on SelectedChannelType from Expression to ContrastEnhancement.

One problem is that I cannot maintain full backwards compatability since i need to change the return type of SelectedChannelType#getContrastEnhancment(). That being said I have made the change in my local sandbox and the build remains fine. So it stands that it may break some client code.

Justin I am not sure the coverage dudes have gotten around to using RasterSymbolizer yet - so no coverage code that I know of will break. As for breaking - if it does not match the specification we should fix it (the interfaces were just matching SLD 0.71) - sad part is Cory and I just checked everything against SLD 1.0 spec - apparently you founds something we missed :-(

One thing out of many. I am impressed how well the model and the spec match up.
True, the interfaces are good - what is freaking me out is the implementations. The event stuff, heck even changing stuff at all, is pointing out a lot of bugs.

Style is kind of the tip of the ice burg, all these problems exist with Filter/Expression as well - and I have not hooked up events there yet. We are looking at duplicating Filter/Expression as part of the unstable Stroke bug.

Jody


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to