Hi Justin, Thank you for the new projection. I have hardly had any time to do any geotools work in the last half year, but 2.2 already has two new projections!
I wont have much time to review this until the weekend, but here are a few comments after looking at the code for 5 minutes (they build on Martin's comments). When the class inherits from MapProjection, you will no longer need the a, Eo, No fields, since they are in MapProjection and called semiMajor, falseEasting and falseNorthing. Also, MapProjection will get these values from the projection parameters, so you will not want to hard code in a value for a (though this projection is only used with one set of parameters). I cannot remember if there is a way to set a default value for parameters, but there used to be in geotools 2.0. Also, in keeping with the naming conventions in the projection subpackage, the class should probably be renamed to the full NewZealandMapGrid. If no one get around to making these changes by saturday, I will do them. Rueben On Tue, 2005-06-12 at 22:11 -0800, Justin Deoliveira wrote: > Hi Mark, > > Thanks for sending the "kick me in the pants email" or I would have put > this off even longer. It was just that going through a bunch of complex > formulas to figure out where i was losing 0.001 degrees was not at the > top of my list. I am sure you can understand :) > > But I sucked it up and figured out what the problem was so things should > be fine now. > > Rueben, if you want to do a code review that would be great. The > relevant class is NZMGTransform. > > If someone on the udig team can build a new main jar from the latest > geotools trunk so Mark can try it out that would be great. I am sure > they will be tommorow with all the style madness going on. > > -Justin > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
