Cool. If you could report on where they are extensively used that would
be helpful too. It is official GeoTools policy to use the logger, so
any use of the System stuff is very bad. If you come up with a list
I'll try to spend some spare cycles on removing them as well...
thanks,
Chris
John Grange wrote:
I'll see what I can do on my spare cycles....
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Brent Owens
Sent: Tuesday, February 21, 2006 1:51 PM
To: John Grange
Cc: [email protected]
Subject: Re: [Geotools-devel] Usage of System.out and System.err vs Logger
Hi John,
It might take a while for the module maintainers to get around to
changing the system outs to proper logging. I'm sure if you submitted
the changed files to one of us with commit access, they could be rolled
in easily and in a timely manner.
Just at the current time there is heavy development going on with the
complex feature model and I don't think many of the developers have any
spare cycles to make the changes.
I thought the amount of system outs was much smaller and mostly isolated
in test cases, and as such not something to worry about. But 200 is
getting up there and they should be rolled into the logging system.
Thanks for bringing this to our attention.
Brent Owens
(The Open Planning Project)
John Grange wrote:
Hi,
I'm in the process of working on a J2EE project that is using geotools
quite extensively. Geotools is great, but there appears to be a
somewhat irritating use of System.out.print* and System.err.print*
peppered throughout the code (207 and 43 occurrences respectively in
the 2.2.trunk tree).
Surely, it is better to use only one logging mechanism as this can be
effectively re-directed and controlled (to be fair, there are 2602
references to this in the source tree). The use of System.*
completely messes up my stdout logs & causes a huge amount of
unneccessary logfiles in a production system.
I would go through and alter the relevant statements, but they are
peppered widely throughout the source and I do not have write access
to the svn repository. I would suggest that module maintainers do
this as part of the release process.
FYI, the searches I carried out are:
grep -r System.out * | grep -v test | grep -v "//" | grep -v ".svn" |
grep -v spike | grep -v scripts | grep -v javadoc | grep -v demo | wc -l
grep -r System.err * | grep -v test | grep -v "//" | grep -v ".svn" |
grep -v spike | grep -v scripts | wc -l
grep -r LOGGER * | grep -v Logger.getLogger
Kind regards and thanks for all the hard work,
John Grange
Senior Software Engineer
Tel: +44 (0)1749 834922
email:_ [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>_
BlueFinger Limited
Underwood Business Park
Wookey Hole Road, WELLS. BA5 1AF
Tel: +44 (0)1749 834900
Fax: +44 (0)1749 834901
web:_ www.bluefinger.com_
Company Reg No: 4209395 Underwood Business Park, Wookey Hole Road,
Wells, Somerset BA5 1AF.
*** This E-mail contains confidential information for the addressee
only. If you are not the intended recipient, please notify us
immediately. You should not use, disclose, distribute or copy this
communication if received in error. No binding contract will result
from this e-mail until such time as a written document is signed on
behalf of the company. BlueFinger Limited cannot accept responsibility
for the completeness or accuracy of this message as it has been
transmitted over public networks.***
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Chris Holmes
The Open Planning Project
thoughts at: http://cholmes.wordpress.com
begin:vcard
fn:Chris Holmes
n:Holmes;Chris
org:The Open Planning Project
adr:;;377 Broadway, 11th Floor;New York;NY;10013;USA
email;internet:[EMAIL PROTECTED]
title:VP, Strategic Development
x-mozilla-html:FALSE
url:http://topp.openplans.org
version:2.1
end:vcard
