I would like to implement this and would like to check if anyone has any objections. The interface should not change except for MaxIncFIDMapper which I believe incorrectly returns hardcoded Types.VARCHAR for the column type when it should return the type of the actual fid column. (Since it assumes that the next fid value is MAX(key_column), it doesn't make sense for this to be a VARCHAR column).
The complete work item is included below. It is difficult to test whether this breaks anything in RDBMS datastores which subclass fidmapper classes as I don't have databases other than DB2 and PostGIS installed. *** Issue details below *** The description of MaxIncFIDMapper states that it is only valid for numeric column types yet the method getColumnSize is hard-coded to return Types.VARCHAR. It also is hard-coded to return a column size of 255. It should return the column type that was specified in the constructor. AbstractFIDMapper has almost no function and all the subclasses have considerable duplicated function. The duplicated function should be factored up. There are also things that make no sense but I don't know if anything will break if they are changed. The getColumnXXX(int col) methods handle index out of bounds by returning null, 0 and ArrayIndexOutOfBounds. They should probably all return ArrayIndexOutOfBounds but this may break other code that doesn't handle an exception. Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
