Justin Deoliveira wrote:

>Reviewed the patch. I could be missing something ( i am pretty
>unfamiliar with this class ) but i think the recursive call to
>readFidColumn on line 44 of the diff should be:
>
>readFidColumn( index + 1 );
>
>instead of
>
>readFidColumn( index );
>
>So if I am not mistaken this code catches an exception that is thrown by
>the jdbc driver which occurs when trying to turn an oid into an integer?
>It seems strange to me that the jdbc driver doesn't handle this
>directly. Actually doing some looking it seems that others have the same
>issue and patch the jdbc driver accordingly.
>
>http://db.apache.org/torque/version-specific/database-howtos/postgres-howto.html
>
>I wonder why the driver doesn't map to a type with a larger value space.
>  
>
You are correct... my bad.  Well, hitting 2 billions records is pretty 
rare...

Are people happy with this patch?

Cory.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to