Justin Deoliveira wrote: > Hi Jody, > > Looking over things: > > 1. It looks like you have FidFilterImpl still implementing the FeatureId > interface, I think it should now implement the Id interface instead. > > 2. FilterVisitor#visit( FeatureId,Object) needs to be changed to > FilterVisitor#visit( Id, Object ); > > 3. The methods from geoapi.FilterFactory go on the Expr class, which is > then extended geotools.FilterFactoryImpl, so moving featureId(String) > and id( Set ids ) there. > > 4. Created a FeatureIdImpl class which implements FeatureId. > > Let me know what you think, I will hold off on committing for now. Go ahead, I just needed the new GeoAPI jar so I could start messing with Filter.NONE & Filter.ALL.
I will be making changes to the DataStore API to accept GeoAPI filter later today (if it has not been done already). I don't plan to use the GeoTools interface at all in the oracle datastore. Jody ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
