On Wednesday 07 February 2007 19:22, Jody Garnett wrote:
> Thanks Gabriel; my earlier comment was one of surprise (the
> functionality you described was working in Novemeber - I have been
> remiss in letting a patch break it, or not capturing the functionality
> in test cases)
>
> That said - did you provide a test case for this functionality in main?
Just did (going to.commit in a couple minutes)
Also note I'm going to fix the Expression implementations as they (except
AttributeExpression) don't make use of Object neither. Most of them relies on
DefaultExpression.evaluate(Object), which does:
public Object evaluate(Object object) {
if (object instanceof Feature || object == null) {
return evaluate((Feature)object);
}
return null;
}
Adding test cases right now before fixing it.
Gabriel
> Jody
>
> > On Wednesday 07 February 2007 11:25, Andrea Aime wrote:
> >> Gabriel Roldán ha scritto:
> >>> On Tuesday 06 February 2007 23:28, Jody Garnett wrote:
> >>>> Justin Deoliveira wrote:
> >>>>> I see a couple of issues with this approach. And I know that I have
> >>>>> voiced these before but I cant turn down the opportunity to do it
> >>>>> again :)
> >>>>
> >>>> That said I am glad to see the code appearing in an unsupported module
> >>>> (and used to test our Filter implementation) these are the first steps
> >>>> after all.
> >>>
> >>> That means its ok to _fix_ the Filter issue provided that no additional
> >>> burden is added (no reference to the new model, just letting
> >>> evaluate(Object) being called after all)?
> >>
> >> Gabriel, go for it please.
> >> If Jody did not want you to work on it, he should have said it directly.
> >
> > ok, so I went ahead and fixed it. Also made FidFilter.evaluate(Object) to
> > use PropertyAccessor.get(object, "@id") to abstract it out from the type
> > of object being evaluated.
> >
> > Gabriel
> >
> >> Cheers
> >> Andrea
--
Gabriel Roldán ([EMAIL PROTECTED])
Axios Engineering (http://www.axios.es)
Tel. +34 944 41 63 84
Fax. +34 944 41 64 90
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
